Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argon2-cffi-bindings): Build on Python 3.12 #1795

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Sep 5, 2024

WIP broken test for fixing this package. Workaround:

  {
    argon2-cffi-bindings = prev.argon2-cffi-bindings.override {
      preferWheel = true;
    };
  }

Contribution checklist (recommended but not always applicable/required):

  • There's an automated test for this change
  • Commit messages or code include references to related issues or PRs (including third parties)
  • Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"

l0b0 added a commit to linz/emergency-management-tools that referenced this pull request Sep 6, 2024
- Reintroduce now-working GitHub Workflows validation
- Use Python 3.12
- Bump all Python packages
- Work around argon2-cffi-bindings being incompatible with Python 3.12
  <nix-community/poetry2nix#1795>
- Patch sat-search and sat-stac for Python 3.12 compatibility
- Add Poetry packages to `python` with multiple `withPackages` calls to avoid
  collisions
- Avoid using very out of date sat-stac package
l0b0 added a commit to linz/emergency-management-tools that referenced this pull request Sep 6, 2024
- Reintroduce now-working GitHub Workflows validation
- Use Python 3.12
- Bump all Python packages
- Work around argon2-cffi-bindings being incompatible with Python 3.12
  <nix-community/poetry2nix#1795>
- Patch sat-search and sat-stac for Python 3.12 compatibility
- Add Poetry packages to `python` with multiple `withPackages` calls to avoid
  collisions
- Avoid using very out of date sat-stac package
l0b0 added a commit to linz/emergency-management-tools that referenced this pull request Sep 6, 2024
- Reintroduce now-working GitHub Workflows validation
- Use Python 3.12
- Bump all Python packages
- Work around argon2-cffi-bindings being incompatible with Python 3.12
  <nix-community/poetry2nix#1795>
- Patch sat-search and sat-stac for Python 3.12 compatibility
- Add Poetry packages to `python` with multiple `withPackages` calls to avoid
  collisions
- Avoid using very out of date sat-stac package
@l0b0 l0b0 marked this pull request as draft September 8, 2024 21:59
@cpcloud cpcloud force-pushed the argon2-cffi-bindings-python-3-12 branch from 46ea650 to 1d4f7f5 Compare October 10, 2024 11:50
@cpcloud cpcloud marked this pull request as ready for review October 10, 2024 11:50
@cpcloud
Copy link
Collaborator

cpcloud commented Oct 10, 2024

The fix here was to generate the correct lockfile. The source distribution was missing for cffi so the bindings never got built and thus the error.

@cpcloud cpcloud merged commit 39439be into nix-community:master Oct 10, 2024
186 checks passed
@l0b0 l0b0 deleted the argon2-cffi-bindings-python-3-12 branch October 10, 2024 20:41
l0b0 added a commit to linz/emergency-management-tools that referenced this pull request Oct 13, 2024
- Reintroduce now-working GitHub Workflows validation
- Use Python 3.12
- Bump all Python packages
- Work around argon2-cffi-bindings being incompatible with Python 3.12
  <nix-community/poetry2nix#1795>
- Patch sat-search and sat-stac for Python 3.12 compatibility
- Add Poetry packages to `python` with multiple `withPackages` calls to avoid
  collisions
- Avoid using very out of date sat-stac package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants