Re-invert behavior of --no-substitute-on-destination #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
force-pushed
the
b/fix-substitute-on-destination
branch
from
a86402e
to
dcae7a8
Compare
Mic92
reviewed
Sep 18, 2024
|
@chreekat please test again. |
Accidentally inverted in 7637325
Mic92
force-pushed
the
b/fix-substitute-on-destination
branch
from
71c9a04
to
95efb19
Compare
|
I don't have a spare target machine atm, but I like your version better and it "looks right" 🚀 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe there's a better way to do this, but it looks like removing elements from an array is kind of a pain.