Fixes relating to --build-on-remote #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #347 Co-Authored-By: mangoiv <[email protected]>
|
cc @Enzime for review |
Enzime
approved these changes
Sep 16, 2024
Mic92
force-pushed
the
build-remote-fixes
branch
2 times, most recently
from
d04f3b1
to
d63c7de
Compare
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
Due to the Terraform variables being passed to `run-nixos-anywhere.sh` via environment variables, these environment variables wound up getting passed to `nixos-anywhere`. `nixos-anywhere` would then read the value `false` which would break everything as it expects the variable to be unset or set to `y`, leading to `disko_script` not being set.
Mic92
force-pushed
the
build-remote-fixes
branch
from
d63c7de
to
0216410
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at fadbb63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #366
rebased version of the same