Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout: add seperate flags for reboot and ssh timeout #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hsjobeki
Copy link

@hsjobeki hsjobeki commented Aug 8, 2024

cc: @Lassulus since you added the infinite loops; Can you check if this works for you?

@Lassulus
Copy link
Contributor

it seems the script aborts after the first ssh error if the retry_limits are not defined

@hsjobeki hsjobeki force-pushed the feat/timeout branch 3 times, most recently from e8cb59f to 7679a56 Compare August 13, 2024 10:30
Copy link
Contributor

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but not tested

@phaer
Copy link
Member

phaer commented Oct 19, 2024

Logic LGTM, but as written --reboot-retry-limit doesn't seem to have to do anything with the actual reboot (into the installed system, at the very end), but just retries connecting after kexec. While kexec could be considered a form of reboot, I think this naming could confuse users and would suggest something like --kexec-connection-retries or so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants