force use of bash to allow for non-posix user shells #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify rebase |
✅ Branch has been successfully rebased |
|
@mergify rebase |
❌ Unable to rebase: user
|
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 2e1bf86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use fish, but the current command will likely fail with nushell and others. Make the bash call explicit to avoid failures such as:
Ideally this would be handled in
_ssh, but there are some sporadic args for ssh in some of the calls. A quick perusal looked like they were just connection timeout options, which I'm wondering if we can move into_ssh. If this was done, then all calls could pass through bash. For now I've targeted the steps that require posix/bashisms.