Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add trailing newline to keyfile #176

Closed
wants to merge 1 commit into from

Conversation

StillerHarpo
Copy link

pass will add an trailing newline which renders luks login via prompt useless

pass will add an trailing newline which renders luks login via prompt useless
@phaer
Copy link
Member

phaer commented Aug 14, 2023

Nice catch, but as that's mostly an example I think the better solution might be to add a check or just strip trailing newlines for any keyFiles? (i.e. #161 (comment))

@StillerHarpo
Copy link
Author

I'm going to fix this in disko directly with nix-community/disko#323. So we can close this without merging after that got merged

@phaer
Copy link
Member

phaer commented Aug 16, 2023

Thanks, has been merged in disko!

@phaer phaer closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants