Default to ssh-ng and and builders-use-substituters #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but still allow disabling substitutions in general.
|
Ah right, I forgot that ssh-ng still has a few unsolved complexities in relation to other flags, as described for example in NixOS/nix#5010 |
|
@phaer any chance you'd want to make it an opt-in feature for now? |
Mic92
reviewed
Aug 28, 2023
| @@ -46,6 +46,8 @@ Options: | |||
| URL of the source Nix store to copy the nixos and disko closure from | |||
| * --build-on-remote | |||
| build the closure on the remote machine instead of locally and copy-closuring it | |||
| * --legacy-ssh | |||
There was a problem hiding this comment.
Maybe:
Suggested change
| * --legacy-ssh | |
| * --builder-protocol |
Than we can also support other protocols in future?
|
Still working on this? |
|
Ah no, sorry for leaving this as a draft for so long & thanks for going through stalled PRs :) . I don't plan to set up too many new hosts and don't currently have time for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.