Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move kexec check into kexec codepath #146

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

ajs124
Copy link
Contributor

@ajs124 ajs124 commented Jul 3, 2023

without this, the check gets run and fails even if no kexec will be done e.g. when an installer is booted

@Mic92
Copy link
Member

Mic92 commented Jul 12, 2023

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

queue

🟠 Waiting for conditions to match

  • any of: [🛡 GitHub branch protection]
    • check-neutral=bors
    • check-skipped=bors
    • check-success=bors
  • -draft [:pushpin: queue requirement]
  • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]
  • any of: [:twisted_rightwards_arrows: queue conditions]
    • all of [:pushpin: queue conditions of queue default]

@Mic92
Copy link
Member

Mic92 commented Jul 12, 2023

@mergify rebase

without this, the check gets run and fails even if no kexec will be done
e.g. when an installer is booted
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

rebase

✅ Branch has been successfully rebased

@Mic92
Copy link
Member

Mic92 commented Jul 12, 2023

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

queue

🛑 Branch protection settings are not validated anymore

Branch protection is enabled and is preventing Mergify to merge the pull request. Mergify will merge when branch protection settings validate the pull request once again. (detail: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information.)

@Mic92
Copy link
Member

Mic92 commented Jul 12, 2023

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

refresh

✅ Pull request refreshed

@Mic92
Copy link
Member

Mic92 commented Jul 12, 2023

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

refresh

✅ Pull request refreshed

@Mic92
Copy link
Member

Mic92 commented Jul 12, 2023

@mergify requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@Mic92 Mic92 merged commit abdec7b into nix-community:main Jul 12, 2023
@ajs124 ajs124 deleted the fix/kexec-check branch July 12, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants