Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restore despite primary-key hit #45

Conversation

deemp
Copy link
Collaborator

@deemp deemp commented Jun 9, 2024

Description

Fix the default behavior of skip-restore-on-hit-primary-key.

Motivation and Context

See #43

The action shouldn't by default restore caches when there was a hit on the primary-key.

How Has This Been Tested?

Manually via CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@deemp deemp linked an issue Jun 9, 2024 that may be closed by this pull request
@deemp deemp force-pushed the 43-bug-restore-prefixes-first-match-still-triggers-when-primary-key-matches branch from e3b9d65 to 119b24c Compare June 9, 2024 11:38
@deemp deemp changed the title fix(action): don't restore on primary-key hit by default Fix #43 Jun 9, 2024
@deemp deemp changed the title Fix #43 Fix restore despite primary-key hit Jun 9, 2024
@deemp deemp merged commit 8351fb9 into main Jun 9, 2024
@deemp deemp deleted the 43-bug-restore-prefixes-first-match-still-triggers-when-primary-key-matches branch August 29, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] restore-prefixes-first-match still triggers when primary key matches
1 participant