Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate output-paths for pull-request builds #305

Open
steveej opened this issue Sep 30, 2024 · 2 comments
Open

populate output-paths for pull-request builds #305

steveej opened this issue Sep 30, 2024 · 2 comments

Comments

@steveej
Copy link

steveej commented Sep 30, 2024

in understanding the possible ways to consume artifacts from buildbot-nix i noticed that the outputPaths gets populated only for builds for the default branch.

the use-cases i'm working with depend on pull-request outputs to be accessible publicly. first i was thinking of a postBuildStep for this, however the outputs might just work if they are made available for all builds.

@Mic92
Copy link
Member

Mic92 commented Sep 30, 2024

I would accept the pull request. The original pr already added this feature but it didn't work for GitHub so I removed that part when merging: #243

Since I currently don't have the use case just now, I probably don't implement myself for now.

@Mic92
Copy link
Member

Mic92 commented Oct 1, 2024

You may need to extend the github api whitelist so that github also gets a pull request number:

"github_property_whitelist": ["github.base.sha", "github.head.sha"],

Than I would add a new abstract method to class GitBackend that returns the property name that stores the pull request number for both gitea and github. After that you can restore the code that was added in #243 but use the property name method that you added to make it backend agnostic.

I can handle testing gitea, just add the code for it and but make it work with github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants