MNT: Drop traits upper bound #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3685 +/- ##
=======================================
Coverage 70.83% 70.83%
=======================================
Files 1276 1276
Lines 59314 59320 +6
Branches 9824 9826 +2
=======================================
+ Hits 42013 42019 +6
Misses 16125 16125
Partials 1176 1176 ☔ View full report in Codecov by Sentry. |
effigies
commented
Oct 3, 2024
| @@ -3821,8 +3822,8 @@ class QwarpInputSpec(AFNICommandInputSpec): | |||
| maxlen=5, | |||
| xor=["wmask"], | |||
| ) | |||
| traits.Tuple((traits.Float(), traits.Float()), argstr="-bpass %f %f") | |||
| wmask = traits.Tuple( | |||
| bandpass = Tuple((traits.Float(), traits.Float()), argstr="-bpass %f %f") | |||
There was a problem hiding this comment.
@Shotgunosine I assume this was the original intent?
Comment on lines
+165
to
+175
| if len(p) > 3 and p[3] is not None: | ||
| default_value = p[3] | ||
| if isinstance(traits_type, traits.List) and not isinstance( | ||
| default_value, list | ||
| ): | ||
| default_value = [default_value] | ||
| attr[name] = traits_type( | ||
| p[3], desc=desc[-1], usedefault=True, mandatory=is_mandatory | ||
| default_value, | ||
| desc=desc[-1], | ||
| usedefault=True, | ||
| mandatory=is_mandatory, |
There was a problem hiding this comment.
@skoudoro Could you check my work here? There were a couple failures without this, where a list with default values of None or 2 would fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
traits.BaseTupleto recover the previously lax behavior that allowedTuple()to check the length and types of arguments without insisting on the container. This fixes the problem that traits. 6.4 introduced, which particularly broke JSON load/save of input specs.Closes #3661.