Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider making nipype compatible with traits >= 6.4 #3661

Closed
penguinpee opened this issue Jul 25, 2024 · 2 comments · Fixed by #3685
Closed

Please consider making nipype compatible with traits >= 6.4 #3661

penguinpee opened this issue Jul 25, 2024 · 2 comments · Fixed by #3685

Comments

@penguinpee
Copy link
Contributor

I'm aware that traits 6.4.0 introduced breaking changes and that for that reason the version is pinned to <6.4 (#3501). I'm also aware that there are currently no plans to overhaul nipype.

However, something will break eventually, e.g with a newer Python release, requiring adaption to a newer traits version. Since current supported Fedora releases have all updated traits to >6.4, it's preventing me from packaging nipype for Fedora.

I'm not sure it's within my capabilities to help refactoring (probably not). But is there some documentation, ongoing work or similar, which would allow me to get an idea what needs changing where and what possible culprits may be?

So far, I've seen a single test out of the 2000+ tests failing due to the newer traits version. That's running tests without optional dependencies, which may hide a few additional failures.

@a-detiste
Copy link

same pain on Debian

@effigies
Copy link
Member

Sorry, I thought I had responded to this, but it was probably in some tab that got closed.

When traits 6.4 came out, we saw many more than 1 test fail, so it's possible that they've re-added compatibility shims that would make the process less daunting. If you have a PR to resolve the issue, I'd be willing to review it and get it in.

One caution: Nipype has severe technical debt, most notably in the CI infrastructure. There is very little appetite to spend time on this project, not least because getting it back up to being properly tested would be a massive time sink. I'd be willing to onboard new maintainers, if you've got the interest and time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants