Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Restore access to private attr Nifti1Extension._content #1378

Merged
merged 1 commit into from
Oct 15, 2024
Merged

FIX: Restore access to private attr Nifti1Extension._content #1378

merged 1 commit into from
Oct 15, 2024

Commits on Oct 15, 2024

  1. FIX: Restore access to private attr Nifti1Extension._content 

    nipygh-1336 reused the private attribute ``ext._content`` to exclusively
refer to the ``bytes`` representation of the extension contents.
This neglected that subclasses might depend on this implementation
detail.

Let's be nice to people and rename the attribute to ``_raw`` and provide
a ``_content`` property that calls ``self.get_content()``.

Also adds a test to ensure that multiple accesses continue to work as
expected.
    @effigies
    effigies committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e97f572 View commit details
    Browse the repository at this point in the history