Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert assertion into a warning that we would not use dicom dir tempate option #709

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

yarikoptic
Copy link
Member

To avoid users confusion etc. Ref: #707 (comment)

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aa4c785) 81.95% compared to head (330ed76) 81.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
- Coverage   81.95%   81.93%   -0.02%     
==========================================
  Files          41       41              
  Lines        4139     4140       +1     
==========================================
  Hits         3392     3392              
- Misses        747      748       +1     
Files Coverage Δ
heudiconv/main.py 77.27% <50.00%> (-0.45%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic merged commit c275b93 into nipy:master Sep 28, 2023
8 of 10 checks passed
Copy link

github-actions bot commented Dec 8, 2023

🚀 PR was released in v1.0.1 🚀

@yarikoptic yarikoptic deleted the enh-no-dicom-template branch December 9, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant