Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Fix the order of the 'echo' entity in the filename #542

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

pvelasco
Copy link
Contributor

@pvelasco pvelasco commented Feb 1, 2022

It addresses #541.

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #542 (405d0ac) into master (80a6538) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #542   +/-   ##
=======================================
  Coverage   77.64%   77.64%           
=======================================
  Files          41       41           
  Lines        3167     3167           
=======================================
  Hits         2459     2459           
  Misses        708      708           
Impacted Files Coverage Δ
heudiconv/convert.py 87.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a6538...405d0ac. Read the comment docs.

@yarikoptic
Copy link
Member

Thank you @pvelasco ! At some point we should provide some easy convenience for updating BIDS filenames in a more structured and schema driven way. For now this fix is great to have as is.

@yarikoptic yarikoptic merged commit eddb35c into nipy:master Feb 2, 2022
@yarikoptic yarikoptic added the patch Increment the patch version when merged label Apr 20, 2022
@github-actions
Copy link

🚀 PR was released in v0.11.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants