Add components for Article #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| module Base | ||
| module Button | ||
| class Component < ApplicationComponent |
Generated by 🚫 Danger |
malparty
reviewed
Sep 24, 2021
Comment on lines
+26
to
+28
| @options = options | ||
|
|
||
| @options[:tag] ||= :a |
There was a problem hiding this comment.
I was wondering a few days ago how to have a clean solution that accepts both <button> and <a> tags :)
That way is nice!
One question though: If the tag is 'button', should we remove the default value of the link param?
There was a problem hiding this comment.
That makes sense. Will do that,
malparty
approved these changes
Sep 24, 2021
|
@rafayet-monon please pull the last commit on your local branch (d1c587d), I've added minor changes so that Unit Tests passes ;-) |
…/rails-view-component-blog into feature/articles-view-component
|
|
||
| private | ||
|
|
||
| def classes(type) |
There was a problem hiding this comment.
| Doesn't depend on instance state (maybe move it to another class?) |
junan
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially does some tickets component part-
What happened
Add components in articles
Insight
Added components for
Proof Of Work
Test cases should pass