Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#436] Fix invalid workflow bug for publish wiki workflow #437

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

mosharaf13
Copy link
Contributor

@mosharaf13 mosharaf13 commented Jul 6, 2023

close #436

What happened 👀

  • Fix invalid workflow file bug for publish wiki workflow.

Insight 📝

  • with section wasn't getting access to secrets context.
    with:
      USER_NAME: github-wiki-workflow
      USER_EMAIL: ${{ secrets.GH_EMAIL }}
    secrets:
      USER_TOKEN: ${{ secrets.GH_TOKEN }}
  • As suggested in this RFC, used this new action to handle wiki publish.

Proof Of Work 📹

https://github.com/mosharaf13/rails-template-wiki/actions/runs/5485979793

Screen Shot 2023-07-10 at 2 09 18 PM

Copy link
Contributor

@sanG-github sanG-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mosharaf, related to this RFC, and also based on the votes, I think we should better take this opportunity to convert to using the publish-github-wiki-action instead.

Please let us know if you faced any obstacles when implementing it, thank you!!!!

@mosharaf13
Copy link
Contributor Author

Hi Mosharaf, related to this RFC, and also based on the votes, I think we should better take this opportunity to convert to using the publish-github-wiki-action instead.

Please let us know if you faced any obstacles when implementing it, thank you!!!!

Fixed in e608fae

Thanks for the suggestion. I used the workflow file suggested in the RFC with new github action. Please let me know if anything needs to be changed.

Copy link
Contributor

@sanG-github sanG-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for expressing the changes!! 🚀

@malparty malparty added this pull request to the merge queue Jul 17, 2023
Merged via the queue into develop with commit 7f0418c Jul 17, 2023
5 checks passed
@malparty malparty deleted the bug/gh-436-fix-publish-wiki-workflow branch July 17, 2023 02:16
@malparty malparty added this to the 5.7.0 milestone Jul 26, 2023
@malparty malparty mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Invalid publish wiki workflow
4 participants