Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues preventing installing dependencies for web development #46

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

augustine-tran
Copy link

https://github.com/nimblehq/laptop/issues/??

What happened

Describe the big picture of your changes here to communicate to the team why we should accept this pull request.

Insight

Describe in details how to test the changes, which solution you tried but did not go with, referenced documentation is welcome as well.

Proof Of Work

Show us the implementation: screenshots, gif, etc.

@breenatheseira
Copy link

breenatheseira commented Oct 15, 2024

Hey @augustine-tran, thanks for this!

Do you think you can also add the ulimit -n 1024 command before Erlang is installed, and maybe ulimit -n 256 once the installation is completed?

I ran the script and the next error that popped up was fatal error: cannot open file ... Too many open files.

The solution was to run the ulimit command and re-run the script.

I could also open a PR based on your fix, if you'd like?

@augustine-tran
Copy link
Author

Do you think you can also add the ulimit -n 1024 command before Erlang is installed, and maybe ulimit -n 256 once the installation is completed?

@breenatheseira I'm on the fence about forcing developers into this configuration. I'd prefer to let the developers be aware of occasional errors and how to solve them rather than force them. That's why I still think my updated script is quite dirty and not ready to merge. I want to add a try/catch code to show error messages and suggestions for solving them more clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants