[12] Integrate Moko Resources to share project resources between platforms #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kover report:🧛 Unit Tests Code Coverage:
|
| File | Coverage |
|---|---|
HomeScreen.kt |
0.00% |
Strings.kt |
0.00% |
Modified Files Not Found In Coverage Report:
Dependencies.kt
Dependencies.kt
Gemfile.lock
Plugins.kt
Plugins.kt
Podfile.lock
Versions.kt
Versions.kt
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
project.pbxproj
strings.xml
strings.xml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
AVI5HEK
force-pushed
the
feature/12-moko-resources
branch
4 times, most recently
from
733215b
to
9d544fd
Compare
AVI5HEK
changed the base branch from
develop
to
feature/29-reuse-android-module-from-android-templates
AVI5HEK
force-pushed
the
feature/12-moko-resources
branch
2 times, most recently
from
9828b2b
to
50865c4
Compare
AVI5HEK
changed the base branch from
feature/29-reuse-android-module-from-android-templates
to
develop
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return if (args.isEmpty()) { | ||
| StringDesc.Resource(id).toString(context = context) | ||
| } else { | ||
| id.format(*args.toTypedArray()).toString(context) |
There was a problem hiding this comment.
| In most cases using a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty. |
| return if (args.isEmpty()) { | ||
| StringDesc.Resource(id).localized() | ||
| } else { | ||
| id.format(*args.toTypedArray()).localized() |
There was a problem hiding this comment.
| In most cases using a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty. |
AVI5HEK
force-pushed
the
feature/12-moko-resources
branch
from
50865c4
to
f78241f
Compare
AVI5HEK
requested review from
suho,
luongvo,
phongvhd93,
markgravity,
lydiasama and
kaungkhantsoe
as code owners
AVI5HEK
force-pushed
the
feature/12-moko-resources
branch
from
f78241f
to
c52faf4
Compare
AVI5HEK
force-pushed
the
feature/12-moko-resources
branch
from
2fe0b62
to
26ea55f
Compare
luongvo
changed the base branch from
develop
to
feature/29-reuse-android-module-from-android-templates
sample/shared/build.gradle.kts
Outdated
| @@ -59,6 +62,11 @@ kotlin { | |||
| implementation(AUTH) | |||
| } | |||
|
|
|||
| with(Dependencies.Moko) { | |||
| api(RESOURCES) | |||
| // api(RESOURCES_COMPOSE) FIXME: Cannot build the shared module with this dependency | |||
There was a problem hiding this comment.
I am not sure what is the issue with this dependency but I can build the project with this line @AVI5HEK. Can you please provide the logs of the error?
Screen.Recording.2023-09-28.at.8.39.15.AM.mov
Base automatically changed from
feature/29-reuse-android-module-from-android-templates
to
develop
October 2, 2023 07:12
AVI5HEK
force-pushed
the
feature/12-moko-resources
branch
from
8f37830
to
9c79a0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
Add Moko Resources to the template.
Insight 📝
:sharedmodule fails to build if we add the dependencydev.icerock.moko:resources-compose:0.23.0. This line has been commented out for now until a resolution is found.expectandactualclasses and methods ofStringsas a helper to get the strings from Moko resources in both the Android and iOS apps.Proof Of Work 📹
Android
iOS