[#169] [iOS] Add mirrored workflows at the root project to test the iOS app publishing workflows #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doannimble
changed the title
doannimble
force-pushed
the
chore/169-mirrored-workflow-ios
branch
from
4cb37be
to
71add25
Compare
doannimble
changed the base branch from
develop
to
chore/226-update-secrets-management
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
had a problem deploying
to
production
GitHub Actions
Failure
doannimble
force-pushed
the
chore/169-mirrored-workflow-ios
branch
from
6b78bb0
to
4e4e688
Compare
luongvo
reviewed
Aug 31, 2023
...emplate/__brick__/{{project_name.snakeCase()}}/.github/workflows/ios_deploy_to_app_store.yml
Outdated
Show resolved
Hide resolved
...mplate/__brick__/{{project_name.snakeCase()}}/.github/workflows/ios_deploy_to_testflight.yml
Outdated
Show resolved
Hide resolved
...emplate/__brick__/{{project_name.snakeCase()}}/.github/workflows/ios_deploy_to_app_store.yml
Outdated
Show resolved
Hide resolved
|
@doannimble There are still many unresolved reviews from my review round here. Could you please re-check again as you missed all hidden comments?
|
luongvo
requested changes
Sep 6, 2023
There was a problem hiding this comment.
@doannimble Some extra issues with formatting & 1 broken result. The rest lgtm.
...emplate/__brick__/{{project_name.snakeCase()}}/.github/workflows/ios_deploy_to_app_store.yml
Outdated
Show resolved
Hide resolved
...mplate/__brick__/{{project_name.snakeCase()}}/.github/workflows/ios_deploy_to_testflight.yml
Outdated
Show resolved
Hide resolved
...emplate/__brick__/{{project_name.snakeCase()}}/.github/workflows/ios_deploy_to_app_store.yml
Outdated
Show resolved
Hide resolved
...mplate/__brick__/{{project_name.snakeCase()}}/.github/workflows/ios_deploy_to_testflight.yml
Outdated
Show resolved
Hide resolved
...emplate/__brick__/{{project_name.snakeCase()}}/.github/workflows/ios_deploy_to_app_store.yml
Outdated
Show resolved
Hide resolved
...mplate/__brick__/{{project_name.snakeCase()}}/.github/workflows/ios_deploy_to_testflight.yml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
APP_STORE_KEY_ID,APP_STORE_ISSUER_ID,APPSTORE_CONNECT_API_KEY_BASE64to Environmentssync_appstore_production_signing,build_and_upload_testflight_production_app, andupload_production_build_to_testflightto fastlaneInsight 📝
chore/169-mirrored-workflow-iosas pushed branch, then we can run the flow.Proof Of Work 📹
Upload to Test Flight
Upload to App Store