Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#255] Generate sample project as a part of test workflow #259

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

nmint8m
Copy link
Contributor

@nmint8m nmint8m commented Aug 1, 2023

What happened 👀

In this PR, I did the following requirements:

Insight 📝

In the job generate_sample_project I add jobs.job_id.needs to generate_mason_bundle to identify that the job generate_mason_bundle must complete successfully before this generate_sample_project job will run

  generate_sample_project:
    needs: generate_mason_bundle

Proof Of Work 📹

Without changes

Skip the job generate_sample_project

image

With changes

It's successfully built: https://github.com/nimblehq/flutter-templates/actions/runs/5724239412/job/15510486424

The job generate_sample_project passed

image

There are 2 new commits:

image

Copy link
Member

@luongvo luongvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest lgtm

Comment on lines 102 to 104
with:
token: ${{ secrets.WIKI_ACTION_TOKEN }}
ref: ${{ github.ref }}
Copy link
Member

@luongvo luongvo Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with token is to checkout repo correctly under bot-nimble account to bypass branch protection https://github.com/nimblehq/flutter-templates/pull/211/files#diff-b6be02f3a9d4c7902a0c7ef15e92a821440068867b5fef0a201f8f254f01e94cR16-R17. I don't think we need it for the bot-account to push a commit to a normal PR.

.github/workflows/test.yml Show resolved Hide resolved
@luongvo
Copy link
Member

luongvo commented Aug 14, 2023

@nmint8m please rebase to have the correct task id as #255 instead 🙏

image

@luongvo luongvo changed the title [#225] Generate sample project as a part of test workflow [#255] Generate sample project as a part of test workflow Aug 14, 2023
.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from @luongvo 's comments, the rest lgtm

@luongvo
Copy link
Member

luongvo commented Aug 18, 2023

@nmint8m Do you have time to resolve reviews on this PR, please? Or I can help you resolve the rest, as this is an important PR for the rest of the contributions 🙏

Copy link
Member

@luongvo luongvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmint8m The commit still uses ticket id as 225, not 255 🙏

.github/workflows/test.yml Outdated Show resolved Hide resolved
@nmint8m nmint8m force-pushed the feature/255-generate-sample branch from dbc8f69 to c8c6983 Compare August 22, 2023 02:32
@luongvo luongvo merged commit 28da793 into develop Aug 22, 2023
3 checks passed
@luongvo luongvo deleted the feature/255-generate-sample branch August 22, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants