[#234] Add secure local storage #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmint8m
changed the title
nmint8m
force-pushed
the
feature/234-secure-storage
branch
from
8fb1e76
to
f3fa964
Compare
luongvo
changed the title
|
@nmint8m is this PR ready for review, please? 👋 |
nmint8m
force-pushed
the
feature/234-secure-storage
branch
from
f3fa964
to
72bf676
Compare
nmint8m
requested review from
luongvo,
manh-t,
markgravity,
sleepylee,
chornerman,
doannimble,
hoangnguyen92dn,
ducbm051291,
thiennguyen0196,
kaungkhantsoe,
Shayokh144,
toby-thanathip and
Wadeewee
as code owners
luongvo
reviewed
Aug 28, 2023
There was a problem hiding this comment.
@nmint8m As we're adding a new feature to the template, could you please help adding a new update in the feature listing from the README?
...
- Networking with [dio](https://pub.dev/packages/dio) and [retrofit](https://pub.dev/packages/retrofit), JSON serializing with [json_serializable](https://pub.dev/packages/json_serializable).
- Integrated local [secure storage](https://pub.dev/packages/flutter_secure_storage).
- [Localization](https://docs.flutter.dev/accessibility-and-localization/internationalization) integrated in [3 initial languages](bricks/template/__brick__/%7B%7Bproject_name.snakeCase()%7D%7D/lib/l10n).
...
bricks/template/__brick__/{{project_name.snakeCase()}}/pubspec.yaml
Outdated
Show resolved
Hide resolved
bricks/template/__brick__/{{project_name.snakeCase()}}/lib/storage/secure_storage.dart
Outdated
Show resolved
Hide resolved
bricks/template/__brick__/{{project_name.snakeCase()}}/lib/storage/secure_storage.dart
Outdated
Show resolved
Hide resolved
bricks/template/__brick__/{{project_name.snakeCase()}}/lib/storage/secure_storage.dart
Outdated
Show resolved
Hide resolved
chornerman
reviewed
Aug 31, 2023
bricks/template/__brick__/{{project_name.snakeCase()}}/pubspec.yaml
Outdated
Show resolved
Hide resolved
nmint8m
force-pushed
the
feature/234-secure-storage
branch
from
9aa269a
to
67bd37f
Compare
luongvo
approved these changes
Aug 31, 2023
chornerman
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
In this PR I added
flutter_secure_storagelibrary to manage the local storage. I also created an example base storage to store and get the access token.Insight 📝
I added the
flutter_secure_storagelibrary. I create a singletonSecureStoragefor managing local storage. Besides, I added 1 variable to get the access token, 1 function to store the access token and 1 function for clearing all stored data.Proof Of Work 📹
N/A