[#169] Define store key id env

nimblehq · Aug 11, 2023 · 2eae2ae · 2eae2ae
1 parent d97a4bb
commit 2eae2ae
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 20 deletions.
diff --git a/bricks/template/__brick__/{{project_name.snakeCase()}}/ios/fastlane/Constants/Constants.rb b/bricks/template/__brick__/{{project_name.snakeCase()}}/ios/fastlane/Constants/Constants.rb
@@ -80,16 +80,6 @@ def self.PRODUCT_NAME_PRODUCTION
     '{{app_name.titleCase()}}'
   end
 
-  # App Store Connect API Key ID
-  def self.APP_STORE_KEY_ID
-    'TKJCMGPSYH'
-  end
-
-  # App Store Connect API Issuer ID
-  def self.APP_STORE_ISSUER_ID
-    '69a6de82-b7cb-47e3-e053-5b8c7c11a4d1'
-  end
-
   # a main target name
   def self.MAIN_TARGET_NAME
     'Runner'

diff --git a/...ks/template/__brick__/{{project_name.snakeCase()}}/ios/fastlane/Constants/Environments.rb b/...ks/template/__brick__/{{project_name.snakeCase()}}/ios/fastlane/Constants/Environments.rb
@@ -15,8 +15,16 @@ def self.TEAM_ID
     ENV['TEAM_ID']
   end
 
-  def self.APPSTORE_CONNECT_API_KEY
-    'LS0tLS1CRUdJTiBQUklWQVRFIEtFWS0tLS0tCk1JR1RBZ0VBTUJNR0J5cUdTTTQ5QWdFR0NDcUdTTTQ5QXdFSEJIa3dkd0lCQVFRZzNLUUdrS2cwK1p1dFIrZTMKbHhrWU5qc1FvUXFsbERLaTliR1hqYVRHcGYrZ0NnWUlLb1pJemowREFRZWhSQU5DQUFRR055cWg3a2RZV2F4bgo1LzF2MzFGcy91N2lYdmZqRHNSSDFXQUhQaDkrUTg1Qjh1SFVIc1Evcy9ZYXRLNWdCZjh4Y01lQW5wd0EzVm9RCk5ZV1JFRjI1Ci0tLS0tRU5EIFBSSVZBVEUgS0VZLS0tLS0='
+  def self.APP_STORE_KEY_ID
+    ENV['APP_STORE_KEY_ID']
+  end
+
+  def self.APP_STORE_ISSUER_ID
+    ENV['APP_STORE_ISSUER_ID']
+  end
+
+  def self.APPSTORE_CONNECT_API_KEY_BASE64
+    ENV['APPSTORE_CONNECT_API_KEY_BASE64']
   end
 
   #################

diff --git a/bricks/template/__brick__/{{project_name.snakeCase()}}/ios/fastlane/Fastfile b/bricks/template/__brick__/{{project_name.snakeCase()}}/ios/fastlane/Fastfile
@@ -155,9 +155,9 @@ platform :ios do
   desc 'Set App Store Connect API key'
   lane :set_connect_api_key do
     app_store_connect_api_key(
-      key_id: Constants.APP_STORE_KEY_ID,
-      issuer_id: Constants.APP_STORE_ISSUER_ID,
-      key_content: Environments.APPSTORE_CONNECT_API_KEY,
+      key_id: Environments.APP_STORE_KEY_ID,
+      issuer_id: Environments.APP_STORE_ISSUER_ID,
+      key_content: Environments.APPSTORE_CONNECT_API_KEY_BASE64,
       is_key_content_base64: true
     )
   end

diff --git a/sample/ios/fastlane/Constants/Environments.rb b/sample/ios/fastlane/Constants/Environments.rb
@@ -15,8 +15,16 @@ def self.TEAM_ID
     ENV['TEAM_ID']
   end
 
-  def self.APPSTORE_CONNECT_API_KEY
-     ENV['APPSTORE_CONNECT_API_KEY']
+  def self.APP_STORE_KEY_ID
+    ENV['APP_STORE_KEY_ID']
+  end
+
+  def self.APP_STORE_ISSUER_ID
+    ENV['APP_STORE_ISSUER_ID']
+  end
+
+  def self.APPSTORE_CONNECT_API_KEY_BASE64
+    ENV['APPSTORE_CONNECT_API_KEY_BASE64']
   end
 
   #################

diff --git a/sample/ios/fastlane/Fastfile b/sample/ios/fastlane/Fastfile
@@ -155,9 +155,10 @@ platform :ios do
   desc 'Set App Store Connect API key'
   lane :set_connect_api_key do
     app_store_connect_api_key(
-      key_id: Constants.APP_STORE_KEY_ID,
-      issuer_id: Constants.APP_STORE_ISSUER_ID,
-      key_content: Environments.APPSTORE_CONNECT_API_KEY
+      key_id: Environments.APP_STORE_KEY_ID,
+      issuer_id: Environments.APP_STORE_ISSUER_ID,
+      key_content: Environments.APPSTORE_CONNECT_API_KEY_BASE64,
+      is_key_content_base64: true
     )
   end