Merge pull request #266 from nimblehq/release/1.11.0

nimblehq · Sep 6, 2023 · 271f3ea · 271f3ea
2 parents 7bc1ac4 + 6c98f12
commit 271f3ea
Show file tree

Hide file tree

Showing 104 changed files with 1,157 additions and 536 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1,6 +1,6 @@
 # Team
 # @luongvo is the Team Lead
-* @luongvo @manh-t @markgravity @sleepylee @chornerman @doannimble @hoangnguyen92dn @nmint8m @ducbm051291 @thiennguyen0196 @kaungkhantsoe @Shayokh144 @Tuubz @Wadeewee
+* @luongvo @manh-t @markgravity @sleepylee @chornerman @doannimble @hoangnguyen92dn @nmint8m @ducbm051291 @thiennguyen0196 @kaungkhantsoe @Shayokh144 @toby-thanathip @Wadeewee
 
 # Engineering Leads
 CODEOWNERS @nimblehq/engineering-leads
diff --git a/.github/ISSUE_TEMPLATE/bug_template.md b/.github/ISSUE_TEMPLATE/bug_template.md
@@ -7,12 +7,12 @@ labels: "type : bug"
 
 ## Issue
 
-Describe the issue you are facing. Show us the implementation: screenshots, gif, etc.
- 
+Describe the issue you are facing. Show us the implementation: screenshots, GIFs, etc.
+
 ## Expected
 
-Describe what should be the correct behaviour.
- 
+Describe what should be the correct behavior.
+
 ## Steps to reproduce
 
 1. 

diff --git a/.github/ISSUE_TEMPLATE/chore_template.md b/.github/ISSUE_TEMPLATE/chore_template.md
@@ -1,14 +1,14 @@
 ---
 name: "Chore"
-about: "Open a Chore for minor update."
+about: "Open a chore issue for a minor update."
 title: "Update "
 labels: "type : chore"
 ---
 
 ## Why
 
-Describe the update details and why it's needed. 
- 
+Describe the update in detail and why it is needed.
+
 ## Who Benefits?
 
 Describe who will be the beneficiaries e.g. everyone, specific chapters, clients...
diff --git a/.github/ISSUE_TEMPLATE/feature_template.md b/.github/ISSUE_TEMPLATE/feature_template.md
@@ -7,8 +7,8 @@ labels: "type : feature"
 
 ## Why
 
-Describe the big picture of the feature and why it's needed. 
- 
+Describe the big picture of the feature and why it is needed.
+
 ## Who Benefits?
 
 Describe who will be the beneficiaries e.g. everyone, specific chapters, clients...
diff --git a/.github/ISSUE_TEMPLATE/story_template.md b/.github/ISSUE_TEMPLATE/story_template.md
@@ -0,0 +1,22 @@
+---
+name: "Story"
+about: "Open a feature story"
+title: "[Type] As a user, I can "
+labels: "type : feature"
+---
+
+## Why
+
+Describe the idea of the user story as in what the motive of the user story is.
+
+## Acceptance Criteria
+
+List down how the user story will be tested and what criteria are necessary for the user story to be accepted.
+
+## Design
+
+(Optional) Add design screenshots or Figma links for UI/UX-related stories.
+
+## Resources
+
+(Optional) Add useful resources such as links to documentation, implementation ideas, or best practices.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -3,19 +3,18 @@ template, e.g. `{Github PR URL}?template=release_template.md`
 
 --
 
-- Solves #
+- Close #
 
 ## What happened 👀
 
-Describe the big picture of your changes here to communicate to the team why we should accept this pull request.
+Provide a description of the **changes** this pull request brings to the codebase. Additionally, when the pull request is still being worked on, a checklist of the planned changes is welcome to track progress.
 
 ## Insight 📝
 
-Describe in details how to test the changes, which solution you tried but did not go with, referenced documentation is
-welcome as well.
+Describe in detail why this solution is the most appropriate, which solution you tried but did not go with, and how to test the changes. References to relevant documentation are welcome as well.
 
 ## Proof Of Work 📹
 
-Show us the implementation: screenshots, gif, etc.
+Show us the implementation: screenshots, GIFs, etc.
 
 <img src="URL_GOES_HERE" width=200 />
diff --git a/.github/wiki/Deployment.md b/.github/wiki/Deployment.md
@@ -10,7 +10,7 @@
   - A new app on Play Store.
 
 - Add these variables as the secrets of CI:
-  - **ENV_PRODUCTION**: the production .env configuration file content.
+  - **ENV**: the production .env configuration file content.
   - **GOOGLE_PLAY_SERVICE_ACCOUNT_JSON**: the json file content of the Play Store's Service Account for app publishing. Please check out [how to create the Service Account](https://support.staffbase.com/hc/en-us/articles/360018569579-Preparing-Automated-Publishing-for-Google-Play-Store).
 
 ### Resources

diff --git a/.github/wiki/Generating-A-Project.md b/.github/wiki/Generating-A-Project.md
diff --git a/.github/wiki/Home.md b/.github/wiki/Home.md
@@ -0,0 +1 @@
+Welcome to the Flutter-Templates wiki!
diff --git a/.github/wiki/_Sidebar.md b/.github/wiki/_Sidebar.md
@@ -0,0 +1,7 @@
+# Table of Contents
+
+- [[Home]]
+
+## Infrastructure
+
+- [[Deployment]]
diff --git a/.github/workflows/android_deploy_production.yml b/.github/workflows/android_deploy_production.yml
@@ -9,6 +9,7 @@ jobs:
   build_and_deploy_android:
     name: Build & Deploy Android
     runs-on: ubuntu-latest
+    environment: production
     timeout-minutes: 30
     steps:
       - name: Check out
@@ -43,9 +44,9 @@ jobs:
 
       - name: Set up .env
         env:
-          ENV_PRODUCTION: ${{ secrets.ENV_PRODUCTION }}
+          ENV: ${{ secrets.ENV }}
         run: |
-          echo $ENV_PRODUCTION > .env
+          echo -e "$ENV" > .env
 
       # App Bundle requires Firebase connected to Play Store to upload https://appdistribution.page.link/KPoa
       - name: Build Android apk
@@ -54,7 +55,7 @@ jobs:
       - name: Deploy Android Production to Firebase
         uses: wzieba/[email protected]
         with:
-          appId: ${{ secrets.FIREBASE_ANDROID_APP_ID_PRODUCTION }}
+          appId: ${{ vars.FIREBASE_ANDROID_APP_ID }}
           serviceCredentialsFileContent: ${{ secrets.FIREBASE_DISTRIBUTION_CREDENTIAL_JSON }}
           groups: ${{ vars.FIREBASE_DISTRIBUTION_TESTER_GROUPS }}
           file: build/app/outputs/flutter-apk/app-production-debug.apk
diff --git a/.github/workflows/android_deploy_production_to_playstore.yml b/.github/workflows/android_deploy_production_to_playstore.yml
@@ -9,6 +9,7 @@ jobs:
   build_and_deploy_android:
     name: Build & Deploy Android
     runs-on: ubuntu-latest
+    environment: production
     timeout-minutes: 30
     steps:
       - name: Check out
@@ -43,17 +44,17 @@ jobs:
 
       - name: Set up .env
         env:
-          ENV_PRODUCTION: ${{ secrets.ENV_PRODUCTION }}
+          ENV: ${{ secrets.ENV }}
         run: |
-          echo $ENV_PRODUCTION > .env
+          echo -e "$ENV" > .env
 
       - name: Set up release signing configs
         env:
           ANDROID_RELEASE_KEYSTORE_BASE64: ${{ secrets.ANDROID_RELEASE_KEYSTORE_BASE64 }}
-          ANDROID_SIGNING_PROPERTIES_BASE64: ${{ secrets.ANDROID_SIGNING_PROPERTIES_BASE64 }}
+          ANDROID_SIGNING_PROPERTIES: ${{ secrets.ANDROID_SIGNING_PROPERTIES }}
         run: |
           echo $ANDROID_RELEASE_KEYSTORE_BASE64 | base64 --decode > android/config/release.keystore
-          echo $ANDROID_SIGNING_PROPERTIES_BASE64 | base64 --decode > android/signing.properties
+          echo "$ANDROID_SIGNING_PROPERTIES" > android/signing.properties
 
       - name: Build Production App Bundle
         run: flutter build appbundle --flavor production --release --build-number $GITHUB_RUN_NUMBER

diff --git a/.github/workflows/android_deploy_staging.yml b/.github/workflows/android_deploy_staging.yml
@@ -9,8 +9,8 @@ jobs:
   build_and_deploy_android:
     name: Build & Deploy Android
     runs-on: ubuntu-latest
-    timeout-minutes: 30
     environment: staging
+    timeout-minutes: 30
     steps:
       - name: Check out
         uses: actions/checkout@v3
@@ -44,9 +44,9 @@ jobs:
 
       - name: Set up .env.staging
         env:
-          ENV_STAGING: ${{ secrets.ENV_STAGING }}
+          ENV: ${{ secrets.ENV }}
         run: |
-          echo $ENV_STAGING > .env.staging
+          echo -e "$ENV" > .env.staging
 
       # App Bundle requires Firebase connected to Play Store to upload https://appdistribution.page.link/KPoa
       - name: Build Android apk
@@ -55,7 +55,7 @@ jobs:
       - name: Deploy Android Staging to Firebase
         uses: wzieba/[email protected]
         with:
-          appId: ${{ secrets.FIREBASE_ANDROID_APP_ID_STAGING }}
+          appId: ${{ vars.FIREBASE_ANDROID_APP_ID }}
           serviceCredentialsFileContent: ${{ secrets.FIREBASE_DISTRIBUTION_CREDENTIAL_JSON }}
           groups: ${{ vars.FIREBASE_DISTRIBUTION_TESTER_GROUPS }}
           file: build/app/outputs/flutter-apk/app-staging-debug.apk
diff --git a/.github/workflows/bump_version.yml b/.github/workflows/bump_version.yml
@@ -16,8 +16,6 @@ jobs:
     steps:
       - name: Check out
         uses: actions/checkout@v3
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Set new version
         uses: jossef/[email protected]

diff --git a/.github/workflows/generate_sample.yml b/.github/workflows/generate_sample.yml
diff --git a/.github/workflows/ios_deploy_staging_to_firebase.yml b/.github/workflows/ios_deploy_staging_to_firebase.yml
@@ -9,6 +9,7 @@ jobs:
   build_and_upload_staging_app_to_firebase:
     name: Build And Upload iOS Staging Application To Firebase
     runs-on: macOS-latest
+    environment: staging
     env:
       TEAM_ID: ${{ secrets.TEAM_ID }}
       FASTLANE_USER: ${{ secrets.FASTLANE_USER }}
@@ -18,7 +19,7 @@ jobs:
       MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
       KEYCHAIN_PASSWORD: ${{ secrets.KEYCHAIN_PASSWORD }}
       FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
-      FIREBASE_APP_ID_STAGING: ${{ secrets.FIREBASE_IOS_APP_ID_STAGING }}
+      FIREBASE_APP_ID: ${{ vars.FIREBASE_IOS_APP_ID }}
       FIREBASE_DISTRIBUTION_TESTER_GROUPS: ${{ vars.FIREBASE_DISTRIBUTION_TESTER_GROUPS }}
       GITHUB_RUN_NUMBER: $GITHUB_RUN_NUMBER
     steps:
@@ -50,9 +51,9 @@ jobs:
 
       - name: Set up .env.staging
         env:
-          ENV_STAGING: ${{ secrets.ENV_STAGING }}
+          ENV: ${{ secrets.ENV }}
         run: |
-          echo $ENV_STAGING > .env.staging
+          echo -e "$ENV" > .env.staging
 
       - name: Run code generator
         run: flutter packages pub run build_runner build --delete-conflicting-outputs