Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#19] [UI] As a logged-in user, I can see the Survey Detail screen #70

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

Thieurom
Copy link
Collaborator

@Thieurom Thieurom commented Aug 29, 2023

What happened 👀

  • Created SurveyScreen (stateless for now).
  • Added route and navigation from HomeScreen to SurveyScreen.

Insight 📝

N/A.

Proof Of Work 📹

Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-08-29.at.10.12.38.mp4

@Thieurom Thieurom added this to the 0.5.0 milestone Aug 29, 2023
@Thieurom Thieurom self-assigned this Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (492d7fe) 48.43% compared to head (2463f27) 48.43%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #70   +/-   ##
========================================
  Coverage    48.43%   48.43%           
========================================
  Files           36       36           
  Lines          384      384           
========================================
  Hits           186      186           
  Misses         198      198           
Flag Coverage Δ
unittests 48.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thieurom Thieurom changed the title [WIP] [#19] [UI] As a logged-in user, I can see the Survey Detail screen [#19] [UI] As a logged-in user, I can see the Survey Detail screen Aug 29, 2023
@Thieurom Thieurom marked this pull request as ready for review August 29, 2023 03:13
Copy link

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

lib/screens/survey/survey_screen.dart Outdated Show resolved Hide resolved
lib/screens/survey/survey_screen.dart Outdated Show resolved Hide resolved
lib/screens/survey/survey_screen.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@nkhanh44 nkhanh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

Copy link

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🏃

@@ -85,6 +85,13 @@ class _HomeScreenState extends ConsumerState<HomeScreen> {
HomePagesWidget(
surveys: surveys,
currentPage: _currentPage,
onNextButtonPressed: () {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thieurom Next time, please move all the action functions outside the build functions. It will reduce the LOC in each function and make it more readability 🙏

@nkhanh44 nkhanh44 merged commit 75f57a8 into develop Aug 30, 2023
4 checks passed
@nkhanh44 nkhanh44 deleted the feature/19-ui-survey-detail branch August 30, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] As a logged-in user, I can see the Survey Detail screen
3 participants