-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#19] [UI] As a logged-in user, I can see the Survey Detail screen #70
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #70 +/- ##
========================================
Coverage 48.43% 48.43%
========================================
Files 36 36
Lines 384 384
========================================
Hits 186 186
Misses 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go 🏃
@@ -85,6 +85,13 @@ class _HomeScreenState extends ConsumerState<HomeScreen> { | |||
HomePagesWidget( | |||
surveys: surveys, | |||
currentPage: _currentPage, | |||
onNextButtonPressed: () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Thieurom Next time, please move all the action functions outside the build functions. It will reduce the LOC in each function and make it more readability 🙏
What happened 👀
SurveyScreen
(stateless for now).HomeScreen
toSurveyScreen
.Insight 📝
N/A
.Proof Of Work 📹
Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-08-29.at.10.12.38.mp4