[#13] [Integrate] As a logged-in user, I can see the Home screen when I relaunch the app

[Thieurom]

• Close [Integrate] As a logged-in user, I can see the Home screen when I relaunch the app #13

What happened 👀

• Implemented HasUserLoggedInUseCase.
• Created SplashViewModel, which depends on HasUserLoggedInUseCase, and integrated with SplashScreen.
• Updated implementation of SecureStorage and TokenDataSource.

Insight 📝

Ideally, if Dart supports static method on an abstract class:

abstract class Serializable {
  factory fromJson(Map<String, dynamic> json);  // <-- won't compile
  Map<String, dynamic> toJson();
}

To overcome this, I had to separate the serializer from the model (serializable), which I think it's not too bad. More detail read here 🙏

It decouples the serialization logic from the actual classes. That means better code readability because classes only contain methods that relate directly to the class — serializers can even be put into their own files.

The other issue was that I couldn't get some tests of TokenDataSource to run correctly. It returns

MissingStubError: 'getValue'
  No stub was found which matches the arguments of this method call:
  getValue({key: SecureStorageKey.apiToken, serializer: Instance of 'ApiTokenSerializer'})

Even I made the following call before that.

when(mockSecureStorage.getValue(
  key: SecureStorageKey.apiToken,
  serializer: ApiTokenSerializer(),
))

Not sure there's a mistake or a mockito thing. I'll keep investigating 🙏

Proof Of Work 📹

KeepLoggedIn.mp4

[codecov]

Codecov Report

Patch coverage: 70.00% and project coverage change: +1.33% 🎉

Comparison is base (8b31157) 49.45% compared to head (51dddf1) 50.78%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop      #66      +/-   ##
===========================================
+ Coverage    49.45%   50.78%   +1.33%     
===========================================
  Files           33       36       +3     
  Lines          366      382      +16     
===========================================
+ Hits           181      194      +13     
- Misses         185      188       +3     

Flag	Coverage Δ
unittests	50.78% <70.00%> (+1.33%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
lib/api/data_sources/token_data_source.dart	68.75% <0.00%> (-11.25%)	⬇️
lib/model/api_token.dart	54.54% <ø> (ø)
lib/storage/secure_storage.dart	0.00% <ø> (ø)
lib/storage/secure_storage_impl.dart	0.00% <0.00%> (ø)
lib/utils/serializer/api_token_serializer.dart	0.00% <0.00%> (ø)
lib/usecases/has_user_logged_in_use_case.dart	85.71% <85.71%> (ø)
lib/screens/splash/splash_view_model.dart	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[doannimble]

Only one tiny concern, the rest lgtm

[doannimble]

(Optional)

Suggested change

	class HasUserLoggedInUseCase implements NoParamsUseCase<bool> {
	class CheckUserLoggedInUseCase implements NoParamsUseCase<bool> {

[nkhanh44]

lgtm