-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#31] [#64] [Integrate] As a logged-in user, I can see the survey list on the Home screen #65
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #65 +/- ##
===========================================
+ Coverage 45.79% 49.45% +3.66%
===========================================
Files 30 33 +3
Lines 297 366 +69
===========================================
+ Hits 136 181 +45
- Misses 161 185 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
74bb112
to
bda39bb
Compare
440ac04
to
7c04fc8
Compare
7c04fc8
to
1605823
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is quite large. These are some initial comments 🙏
968f572
to
3949f75
Compare
3949f75
to
8003a93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, rest lgtm 👍
decaf82
to
8b31157
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now 👍
What happened 👀
Insight 📝
I faced the error when getting token from SecureStorage:
So I just updated the casting at
token_data_source
andsecure_storage_impl
and it works well now.decodedData
instead 🙈 .Proof Of Work 📹
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-23.at.12.25.56.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-22.at.23.15.00.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-22.at.23.12.27.mp4