Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8] [UI] As a user, if I fail to log in, I see an error popup #55
[#8] [UI] As a user, if I fail to log in, I see an error popup #55
Changes from all commits
34cf7bf
c8d6ea4
3ace9b7
79981c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 42 in lib/screens/login/login_view_model.dart
Codecov / codecov/patch
lib/screens/login/login_view_model.dart#L42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask if we need to write unit tests for these to increase the code coverage? as the Codevov just got failed 🙏
https://github.com/nimblehq/flutter-ic-khanh-thieu/pull/55/checks?check_run_id=15928008166
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this too. However, the
login()
method is not integrated with API yet. I think we can supplement unit tests forLoginViewModel
in the integrating task 🙏Check warning on line 11 in lib/uimodels/app_error.dart
Codecov / codecov/patch
lib/uimodels/app_error.dart#L11
Check warning on line 18 in lib/uimodels/app_error.dart
Codecov / codecov/patch
lib/uimodels/app_error.dart#L13-L18
Check warning on line 10 in lib/utils/build_context_ext.dart
Codecov / codecov/patch
lib/utils/build_context_ext.dart#L8-L10
Check warning on line 17 in lib/utils/internet_connection_manager.dart
Codecov / codecov/patch
lib/utils/internet_connection_manager.dart#L17
Check warning on line 19 in lib/utils/internet_connection_manager.dart
Codecov / codecov/patch
lib/utils/internet_connection_manager.dart#L19