Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4] [Chore] Set up the CD with Fastlane and GitHub Actions for iOS - part 2 of 2 #45

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

Thieurom
Copy link
Collaborator

@Thieurom Thieurom commented Aug 2, 2023

What happened 👀

  • Add a new fastlane's lane for building and uploading production app to Test Flight.
  • Create workflow to build and deploy iOS production app.

Insight 📝

N/A

Proof Of Work 📹

  • Workflows ran successfully on GitHub actions (detail):
    Screenshot 2023-08-02 at 16 16 53

  • App's uploaded successfully on TestFight:
    Screenshot 2023-08-03 at 09 13 18

  • Get invited:
    IMG_1927

  • Can install and run app on device:

RPReplay_Final1691029129.MP4

@Thieurom Thieurom added this to the 0.1.0 milestone Aug 2, 2023
@Thieurom Thieurom self-assigned this Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d8df4fc) 19.23% compared to head (1c24a08) 19.23%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #45   +/-   ##
========================================
  Coverage    19.23%   19.23%           
========================================
  Files            3        3           
  Lines           52       52           
========================================
  Hits            10       10           
  Misses          42       42           
Flag Coverage Δ
unittests 19.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thieurom Thieurom force-pushed the chore/4-setup-cd-for-ios-production branch 2 times, most recently from 06c15fb to 082bcb8 Compare August 2, 2023 09:26
@Thieurom Thieurom changed the title [wip] [#4] Set up CD pipeline for deploying iOS production build to TestFlight [#4] Set up CD pipeline for deploying iOS production build to TestFlight - part 2 of 2 Aug 3, 2023
@Thieurom Thieurom marked this pull request as ready for review August 3, 2023 02:21
@Thieurom Thieurom changed the title [#4] Set up CD pipeline for deploying iOS production build to TestFlight - part 2 of 2 [#4] [Chore] Set up the CD with Fastlane and GitHub Actions for iOS - part 2 of 2 Aug 3, 2023
Copy link
Collaborator

@nkhanh44 nkhanh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one concern

.github/workflows/ios_deploy_production_to_testflight.yml Outdated Show resolved Hide resolved
Copy link

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from @nkhanh44 's comment. The rest lgtm

Base automatically changed from chore/4-setup-cd-for-ios to develop August 3, 2023 03:39
@Thieurom Thieurom force-pushed the chore/4-setup-cd-for-ios-production branch from 082bcb8 to 1c24a08 Compare August 3, 2023 03:58
@nkhanh44 nkhanh44 merged commit c7ae959 into develop Aug 3, 2023
4 checks passed
@nkhanh44 nkhanh44 deleted the chore/4-setup-cd-for-ios-production branch August 3, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore] Set up the CD with Fastlane and GitHub Actions for iOS
3 participants