[#9] Add dummy for login response

nimblehq · Aug 11, 2023 · dcb2c53 · dcb2c53
1 parent eedeef0
commit dcb2c53
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 13 deletions.
diff --git a/lib/model/request/login_request.dart b/lib/model/request/login_request.dart
@@ -2,8 +2,6 @@ import 'package:json_annotation/json_annotation.dart';
 
 part 'login_request.g.dart';
 
-const String grantType = "password";
-
 @JsonSerializable()
 class LoginRequest {
   final String grantType;
@@ -20,7 +18,5 @@ class LoginRequest {
     required this.clientSecret,
   });
 
-  factory LoginRequest.fromJson(Map<String, dynamic> json) =>
-      _$LoginRequestFromJson(json);
   Map<String, dynamic> toJson() => _$LoginRequestToJson(this);
 }
diff --git a/lib/model/response/login_response.dart b/lib/model/response/login_response.dart
@@ -31,4 +31,15 @@ class LoginResponse {
         expiresIn: expiresIn,
         refreshToken: refreshToken,
       );
+
+  static LoginResponse dummy() {
+    return LoginResponse(
+      id: "",
+      accessToken: "",
+      tokenType: "",
+      expiresIn: 0,
+      refreshToken: "",
+      createdAt: 0,
+    );
+  }
 }
diff --git a/lib/repositories/authentication_repository.dart b/lib/repositories/authentication_repository.dart
@@ -5,6 +5,8 @@ import 'package:survey_flutter/model/login_model.dart';
 import 'package:survey_flutter/model/request/login_request.dart';
 import 'package:injectable/injectable.dart';
 
+const String _grantType = "password";
+
 abstract class AuthenticationRepository {
   Future<LoginModel> login({
     required String email,
@@ -29,7 +31,7 @@ class AuthenticationRepositoryImpl extends AuthenticationRepository {
         password: password,
         clientId: Env.clientId,
         clientSecret: Env.clientSecret,
-        grantType: grantType,
+        grantType: _grantType,
       ));
       return response.toLoginModel();
     } catch (exception) {

diff --git a/test/api/repositories/authentication_repository_test.dart b/test/api/repositories/authentication_repository_test.dart
@@ -28,14 +28,7 @@ void main() {
     });
 
     test('When login successfully, it returns correct model', () async {
-      final loginResponse = LoginResponse(
-        id: "",
-        accessToken: "",
-        tokenType: "",
-        expiresIn: 0,
-        refreshToken: "",
-        createdAt: 0,
-      );
+      final loginResponse = LoginResponse.dummy();
 
       when(mockAuthApiService.login(any))
           .thenAnswer((_) async => loginResponse);