[#45] Fix: Remove all unnecessary app icons from the lib module #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luongvo
requested review from
hoangnguyen92dn,
lydiasama and
doannimble
as code owners
luongvo
changed the title
luongvo
force-pushed
the
chore/45-clean-up-unnecesary-stuff
branch
3 times, most recently
from
7683ae4
to
04875f2
Compare
luongvo
force-pushed
the
chore/45-clean-up-unnecesary-stuff
branch
from
04875f2
to
39ee55d
Compare
RxJavaTemplate Jacoco report:Generated by 🚫 Danger |
There was a problem hiding this comment.
@luongvo On the new AS, it requires to update to new gradle version, does it happen on your local? I think it's also the timing to update the gradle. Or do you prefer handle in separate issue?
|
@hoangnguyen92dn It happens on my local, too, but I did not push the fix for it. Let me push it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45
What happened 👀
Insight 📝
The lib module MUST NOT provide app resources (icons) that can override the resources from the
appmodule.Proof Of Work 📹