-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/tut1: new section on functions and methods #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change all references to nimskull
You should change the commit author to
When backporting I'd prefer that we keep as much authoring metadata as possible. |
This is a good idea, in starting to review further. We have pr guidelines so could you start sprucing up the description accordingly for others? I don't want to have strong references into Nim as we do things differently and I don't want to give people the wrong omissions as they try and soft through what does and doesn't make sense. |
Wait, do you mean the whole doc? Changing only in the edited section doesn't make a lot of sense.
Not sure I'm following. Sprucing up what description accordingly to what? |
Let me clarify, I recently added
We have a PR template, that should have popped up, please see the contents here, thanks. Specifically, here are some good starting points:
Hope those clarify things, keep the questions coming we'll help ya along! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sneaky ones
commit c4a4a12 Author: Zoom <[email protected]> Date: Sun Dec 12 15:03:50 2021 +0300 Use |NimSkull| in the new text. Fix formatting. commit 2630c7b Author: PMunch <[email protected]> Date: Sat Dec 11 17:52:44 2021 +0000 doc/tut1: new section on functions and methods Co-authored-by: Danil Yarantsev <[email protected]> Co-authored-by: konsumlamm <[email protected]> Co-authored-by: Zoom <[email protected]>
c4a4a12
to
84a26cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bors r+
Thanks, @ZoomRmc! Happy early first commit into nimskull. 🎉 👍🏽 😄 |
Build succeeded: |
This PR adds a new section on functions and methods to the first part of the tutorial.
The added text clarifies the differences between the three and provides some benefits of using
func
s which explains their existence in the language.This PR aims to answer a repeating question of "which of the three should I use?" coming from new language users, which was observed on multiple occasions by the @PMunch and others.
Most of the work is by @PMunch, part about functions coauthored by me in a declined edit of the merged PR (nim-lang/Nim#19207)