shallow fold prevention for addr, nkHiddenAddr
#24322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The regression from #23807 fixed in this is: proc main =
let a = [0, 1, 2]
let x = addr a[low(a)]
main()When the compiler deeply prevents folding, this causes issues for |
metagn
changed the title
nkHiddenAddr same as nkAddraddr, nkHiddenAddr
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Oct 28, 2024
fixes #24305, refs #23807 Since #23014 `nkHiddenAddr` is produced to fast assign array elements in iterators. However the array access inside this `nkHiddenAddr` can get folded at compile time, generating invalid code. In #23807, compile time folding of regular `addr` expressions was changed to be prevented in `transf` but `nkHiddenAddr` was not updated alongside it. The method for preventing folding in `addr` in #23807 was also faulty, it should only trigger on the immediate child node of the address rather than all nodes nested inside it. This caused a regression as outlined in [this comment](#24322 (comment)). To fix both issues, `addr` and `nkHiddenAddr` now both shallowly prevent constant folding for their immediate children. (cherry picked from commit 52cf7df)
narimiran
pushed a commit
that referenced
this pull request
Oct 28, 2024
fixes #24305, refs #23807 Since #23014 `nkHiddenAddr` is produced to fast assign array elements in iterators. However the array access inside this `nkHiddenAddr` can get folded at compile time, generating invalid code. In #23807, compile time folding of regular `addr` expressions was changed to be prevented in `transf` but `nkHiddenAddr` was not updated alongside it. The method for preventing folding in `addr` in #23807 was also faulty, it should only trigger on the immediate child node of the address rather than all nodes nested inside it. This caused a regression as outlined in [this comment](#24322 (comment)). To fix both issues, `addr` and `nkHiddenAddr` now both shallowly prevent constant folding for their immediate children. (cherry picked from commit 52cf7df) (cherry picked from commit 7ad7ee03e5c0adb6832cbae10a62de7b68ef6fa5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24305, refs #23807
Since #23014
nkHiddenAddris produced to fast assign array elements in iterators. However the array access inside thisnkHiddenAddrcan get folded at compile time, generating invalid code. In #23807, compile time folding of regularaddrexpressions was changed to be prevented intransfbutnkHiddenAddrwas not updated alongside it.The method for preventing folding in
addrin #23807 was also faulty, it should only trigger on the immediate child node of the address rather than all nodes nested inside it. This caused a regression as outlined in this comment.To fix both issues,
addrandnkHiddenAddrnow both shallowly prevent constant folding for their immediate children.