^D now works with readLineFromStdin (in particular in nim secret)

[timotheecour]

• follows add linenoise.readLineStatus to get status (eg: ctrl-D or ctrl-C) #16977
• fixes control+D should exit nim secret; quit sometimes doesn't work timotheecour/Nim#533 (quit doesn't always allow quitting, and is a hack as it prevents cleanup work; ^D can now be used instead on platforms supporting linenoise)
• ^D now works with readLineFromStdin (in particular in nim secret; in particular echo 'echo 1' | nim secret now works and exits instead of hanging)
• various other improvements and refactorings (the diff is smaller despite added functionality)
• bugfix for genode which wasn't printing prompt

[Araq]

Bugfixes come with rdstdin API additions, not exactly ideal. If you put effort into "nim secret", can you please move it so that it is a tool of its own?

[timotheecour]

Bugfixes come with rdstdin API additions, not exactly ideal.

ok, see #18448 which can be merged first

If you put effort into "nim secret", can you please move it so that it is a tool of its own?

the API additions are useful for any tool that uses rdstdin not just nim secret; I'm simply using the new APIs to improve nim secret. Splitting nim secret in another tool is a much more involved change that should be discussed separately, it's not at all clear it'd decrease total amount of complexity (but it very well might increase it). nim secret is so far the only published true REPL we have (inim is useful but isn't a true REPL as it re-evaluates everything on each cmd) so improving what we have makes sense.

[Araq]

in another tool is a much more involved change that should be discussed separately, it's not at all clear it'd decrease total amount of complexity (but it very well might increase it).

Maybe but then the Nim compiler itself does not depend on linenoise anymore so that's a benefit.

[timotheecour]

Maybe but then the Nim compiler itself does not depend on linenoise anymore so that's a benefit.

future work can add a plugin interface to compiler so you'd be able to load an optional linenoise-compatible plugin at compiler runtime via nim --linenoise:/pathto/linenoise.so args, which has other use cases. At that point nimlinenoise (it's nim patch) will be able to live in a separate nimble package and be forked.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. If you think it is still a valid PR, please rebase it on the latest devel; otherwise it will be closed. Thank you for your contributions.