Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): Add Mastodon #418

Closed
wants to merge 3 commits into from
Closed

feat(service): Add Mastodon #418

wants to merge 3 commits into from

Conversation

fireynis
Copy link

@fireynis fireynis commented Oct 9, 2022

Description

Added in a client for the Mastodon distributed social network. I used the matt-n library but

Motivation and Context

This was a requested feature for the Notify project here: #6

How Has This Been Tested?

I have not added tests to it, effectively all of the work is done through another package and no real work is done in this file. A unit a test seems not very useful, but I am happy to be wrong.

I am looking for feedback, or this can be something that is merged in and as a second PR I can add tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

@nikoksr nikoksr changed the title Created a Mastodon client feat(service): Add Mastodon client Oct 20, 2022
@nikoksr nikoksr changed the title feat(service): Add Mastodon client feat(service): Add Mastodon Oct 20, 2022
@nikoksr
Copy link
Owner

nikoksr commented Oct 21, 2022

Hi @fireynis, first of all, we greatly appreciate your efforts and contribution. We'd be really excited to merge this into Notify.

Checking your work, I can't fail to notice however that you did not meet certain standards that we're pursuing. Before we go ahead and review your code, I'd ask you to add some (at least) basic documentation and most preferably quality tests.

If there's anything @svaloumas or I can help you with, please let us know! Check out an already existing service like Twilio for details on how to document and test your Notify service.

@fireynis fireynis closed this Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants