Fix Nightwatch commands in waitUntil
callback return NightwatchAPI
instead of a Promise
#4171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4158
The problem is that in
waitUntil
if we pass an async callback towaitUntil
command, Nightwatch commands inside the callback still just return NightwatchAPI and no promise which can be awaited to get the result. While inperform
command, it works fine and Nightwatch commands return a promise inside async callback passed to perfom command, which this is because thealwaysAsync
is settrue
for perform which inturn returns the promise in this code block. Similarly nowwaitUntil
returnspromise
instead of theNightwatchAPI
as expected. Would love to hear any suggestions/opinions.examples/tests
directory of the project) and running them.ecosia.js
andduckDuckGo.js
are good examples to work with.features/my-new-feature
orissue/123-my-bugfix
);