Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning error instead of throwing when passed wrong index in selector #4071

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dikwickley
Copy link
Contributor

@dikwickley dikwickley commented Feb 29, 2024

Fixes: #3810

Fixes: dikwickley/gsoc24#1

Earlier we used to throw the error if the element is not found by it's CSS selector.
Here are few cases

for .expect.element().to.not.be.present test here are some cases

  1. (#wrong_selector) used to return error due to wrong selector, test passes
  2. (#wrong_selector, wrong_index) used to return error due to wrong selector, doesn't go to test for index, test passes
  3. (#right_selector, wrong_index) used to return element as selector was right, but used to throw error when filtering by index (not return it).

This PR fixes that last case.

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

Copy link
Member

@gravityvi gravityvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests

@dikwickley
Copy link
Contributor Author

dikwickley commented Mar 1, 2024

added test for wrong selector index @gravityvi

Comment on lines +304 to +309
return {
status: errorResult.status,
value: null,
error: errorResult.errorStatus,
message: errorResult.message
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this would also change the flow for the assert.visible() and expect.element().visible commands where getting an error is the expected flow.

The expect.element().not.present here should take a similar flow as assert.not.elementPresent() which happens to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants