-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override watch #239
base: dev
Are you sure you want to change the base?
Override watch #239
Commits on May 26, 2024
-
Override refactoring and additional functionnalities
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
Configuration menu - View commit details
-
Copy full SHA for 1f1e3bf - Browse repository at this point
Copy the full SHA 1f1e3bfView commit details -
Override refactoring and additional functionnalities
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
Configuration menu - View commit details
-
Copy full SHA for 7ac38f7 - Browse repository at this point
Copy the full SHA 7ac38f7View commit details -
Override refactoring and additional functionnalities
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
Configuration menu - View commit details
-
Copy full SHA for f1dedc1 - Browse repository at this point
Copy the full SHA f1dedc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d2511f - Browse repository at this point
Copy the full SHA 4d2511fView commit details -
fix a concurrency issue about overrideObserver
use async to update overrideObserver.
Configuration menu - View commit details
-
Copy full SHA for 89af4f0 - Browse repository at this point
Copy the full SHA 89af4f0View commit details -
Add a (purple) color for override fix the name of the class
Configuration menu - View commit details
-
Copy full SHA for b5d5495 - Browse repository at this point
Copy the full SHA b5d5495View commit details -
Fix a issue with duplicate ID target
Fix a issue when you want to extend a current preset.
Configuration menu - View commit details
-
Copy full SHA for cf7fdc5 - Browse repository at this point
Copy the full SHA cf7fdc5View commit details -
Improve override Observer to avoid to have too many call to core date.
Configuration menu - View commit details
-
Copy full SHA for 0cfb7fc - Browse repository at this point
Copy the full SHA 0cfb7fcView commit details -
Add the capacity to manage override with Apple Watch : - allows to select a override preset (or a temp target) in AW - allows to cancel a current override preset or specific override (idem for temp target) in AW - add a color profil for override profil in AW - Fix some minor code in AW
Configuration menu - View commit details
-
Copy full SHA for dd483d9 - Browse repository at this point
Copy the full SHA dd483d9View commit details
Commits on May 31, 2024
-
Limit carb equivalents of FPU conversion to 1.0 grams:
* Extracted the FPU processing logic into a new helper function `processFPU`, which ensures that each carb equivalent is at least 1.0 grams by adjusting the interval if necessary. * Added logic in new helper function`processFPU` to adjust the interval when the calculated carb equivalent is less than 1.0 grams. * Adjusted spread over time by computing duration again so total carb equivalents remain consistent * Refactored the main `storeCarbs` function to be more concise and easier to understand. * Introduced detailed docstrings to explain the purpose and functionality of the `storeCarbs`, `processFPU`, and `calculateComputedDuration` functions.
Configuration menu - View commit details
-
Copy full SHA for 229c701 - Browse repository at this point
Copy the full SHA 229c701View commit details -
Edit profile overrides - Enable edit of all settings and/or name for …
…already saved profile overrides - Swipe left to edit or delete - Get list of all settings included in the override when saving a new one or editing an existing one
Configuration menu - View commit details
-
Copy full SHA for be6a284 - Browse repository at this point
Copy the full SHA be6a284View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5258cb4 - Browse repository at this point
Copy the full SHA 5258cb4View commit details -
Refactor to avoid duplicated code
- presetPopover and editPresetPopover
Configuration menu - View commit details
-
Copy full SHA for 9341509 - Browse repository at this point
Copy the full SHA 9341509View commit details -
Configuration menu - View commit details
-
Copy full SHA for f710d47 - Browse repository at this point
Copy the full SHA f710d47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74e0821 - Browse repository at this point
Copy the full SHA 74e0821View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20aa517 - Browse repository at this point
Copy the full SHA 20aa517View commit details -
Draft 2.0 - Move settings inside edit pop-up
- More intuitive workflow
Configuration menu - View commit details
-
Copy full SHA for ee245ca - Browse repository at this point
Copy the full SHA ee245caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19934f4 - Browse repository at this point
Copy the full SHA 19934f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5df0eee - Browse repository at this point
Copy the full SHA 5df0eeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75c23d0 - Browse repository at this point
Copy the full SHA 75c23d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9185612 - Browse repository at this point
Copy the full SHA 9185612View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ce0ef1 - Browse repository at this point
Copy the full SHA 3ce0ef1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4f14a9 - Browse repository at this point
Copy the full SHA c4f14a9View commit details -
Improve UX with what settings are populated in root and edit views Wh…
…en .onDisappear from the editPresetPopover back to root view behave the same way as .onAppear in root view when coming from home screen, that is: - If ongoing override, populate settings with the ongoing override setting. - If no ongoing override, populate settings with user defaults And when entering edit by selecting edit on any override -> populate the settings in edit mode with that selected overrides settings as starting point for the edit Refactor code based on input from @avouspierre
Configuration menu - View commit details
-
Copy full SHA for 79e658d - Browse repository at this point
Copy the full SHA 79e658dView commit details -
- Change Profile Editor Slider Numbering Positioning (reuse @dnzxy old iAPS commit )
Configuration menu - View commit details
-
Copy full SHA for 475e9de - Browse repository at this point
Copy the full SHA 475e9deView commit details -
- Enable editing Name, Target and Duration for preset temp targets - Swipe left to edit or delete - Replaced display of "Low target - High target" in presetView since only low target is used
Configuration menu - View commit details
-
Copy full SHA for e8c841f - Browse repository at this point
Copy the full SHA e8c841fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2829468 - Browse repository at this point
Copy the full SHA 2829468View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54eba5d - Browse repository at this point
Copy the full SHA 54eba5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for eeeae6e - Browse repository at this point
Copy the full SHA eeeae6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4477b8 - Browse repository at this point
Copy the full SHA d4477b8View commit details -
- Fix mgdl->mmol rounding when using experimental slider - Also rearrange sliders below % text in experimental view (Reusing @dnzxy ols iAPS PR 321) - Reset all changed values/sliders to 0 if cancelling in edit view . Additional commit regarding experimental slider in edit view upcoming soon in part 2
Configuration menu - View commit details
-
Copy full SHA for 2ebd2d8 - Browse repository at this point
Copy the full SHA 2ebd2d8View commit details -
- Experimental slider now available also in editPresetPopover view - All conversion mgdl/mmol tested and seems to work correct - You can switch between normal and experimental view freely while contemplating your edit - Additional features and UI redesigned excluded from scope
Configuration menu - View commit details
-
Copy full SHA for a95c9b4 - Browse repository at this point
Copy the full SHA a95c9b4View commit details -
Calculate insulin % based on saved preset target
- when entering edit mode. This way you can choose "normal" target/duration entries or use the slider to do your edits
Configuration menu - View commit details
-
Copy full SHA for d5b30de - Browse repository at this point
Copy the full SHA d5b30deView commit details -
feat(issue templates): Update with different styling
To make the Issues clearer to read
Configuration menu - View commit details
-
Copy full SHA for 99471b4 - Browse repository at this point
Copy the full SHA 99471b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc8ec73 - Browse repository at this point
Copy the full SHA cc8ec73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1869b18 - Browse repository at this point
Copy the full SHA 1869b18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5628392 - Browse repository at this point
Copy the full SHA 5628392View commit details -
Configuration menu - View commit details
-
Copy full SHA for 183dc8e - Browse repository at this point
Copy the full SHA 183dc8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f212b89 - Browse repository at this point
Copy the full SHA f212b89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98e51e5 - Browse repository at this point
Copy the full SHA 98e51e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f8460e - Browse repository at this point
Copy the full SHA 3f8460eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9620415 - Browse repository at this point
Copy the full SHA 9620415View commit details -
Configuration menu - View commit details
-
Copy full SHA for 654c0e4 - Browse repository at this point
Copy the full SHA 654c0e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1009741 - Browse repository at this point
Copy the full SHA 1009741View commit details -
Override refactoring and additional functionnalities
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
Configuration menu - View commit details
-
Copy full SHA for a3237e3 - Browse repository at this point
Copy the full SHA a3237e3View commit details -
Update override with new overrideprofileview
Update override profile view with integration of the new editor function. sort the preset by name in the override storage
Configuration menu - View commit details
-
Copy full SHA for 5f0359b - Browse repository at this point
Copy the full SHA 5f0359bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f9a677 - Browse repository at this point
Copy the full SHA 1f9a677View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5656423 - Browse repository at this point
Copy the full SHA 5656423View commit details -
Configuration menu - View commit details
-
Copy full SHA for 265b0b3 - Browse repository at this point
Copy the full SHA 265b0b3View commit details -
Bug fix in Update OverrideStorage.swift
<id: preset.id ?? UUID().uuidString,> Breaking bug fix, provide UUID().uuidString when preset.id is null
Configuration menu - View commit details
-
Copy full SHA for 19f4611 - Browse repository at this point
Copy the full SHA 19f4611View commit details
Commits on Jun 1, 2024
-
•Change "exercice" to "exercise" throughout code - needed for NS to process properly as an exercise event •Did not modify FR localization files
Configuration menu - View commit details
-
Copy full SHA for 50fd941 - Browse repository at this point
Copy the full SHA 50fd941View commit details -
- Observer update to reduce the call of core data - manage a id issue between preset and override temp
Configuration menu - View commit details
-
Copy full SHA for 49e19d7 - Browse repository at this point
Copy the full SHA 49e19d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30c310f - Browse repository at this point
Copy the full SHA 30c310fView commit details -
fix padding issue in light mode for override edit
fix proposed by @dnsallfot
Configuration menu - View commit details
-
Copy full SHA for 58bfb82 - Browse repository at this point
Copy the full SHA 58bfb82View commit details -
Update override with improvements asked by Trio team
- remove try? with core date save - use Profile instead Profil - manage the store of enabled attribute in regard of current() - other minor code improvements
Configuration menu - View commit details
-
Copy full SHA for aad337d - Browse repository at this point
Copy the full SHA aad337dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1651ec6 - Browse repository at this point
Copy the full SHA 1651ec6View commit details -
update following the update of override
- update overrideprofile name
Configuration menu - View commit details
-
Copy full SHA for e3eb22e - Browse repository at this point
Copy the full SHA e3eb22eView commit details