fix: MIT Weekend Reads article can have empty descriptions

nicopico-dev · Sep 4, 2024 · 13f0aa8 · 13f0aa8
1 parent 4f38f2f
commit 13f0aa8
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 2 deletions.
diff --git a/src/main/kotlin/fr/nicopico/n2rss/newsletter/handlers/MITWeekendReadsNewsletterHandler.kt b/src/main/kotlin/fr/nicopico/n2rss/newsletter/handlers/MITWeekendReadsNewsletterHandler.kt
@@ -17,8 +17,8 @@
  */
 package fr.nicopico.n2rss.newsletter.handlers
 
-import fr.nicopico.n2rss.newsletter.models.Article
 import fr.nicopico.n2rss.mail.models.Email
+import fr.nicopico.n2rss.newsletter.models.Article
 import fr.nicopico.n2rss.newsletter.models.Newsletter
 import org.jsoup.Jsoup
 import org.jsoup.safety.Safelist
@@ -56,7 +56,8 @@ class MITWeekendReadsNewsletterHandler : NewsletterHandlerSingleFeed {
                     ?: return@mapNotNull null
                 val title = h2.text().trim()
                 val description = h2.nextElementSiblings().select("p").firstOrNull()?.ownText()
-                    ?: throw NewsletterParsingException("Cannot find description for article \"$title\"")
+                // Articles can have no description
+                    ?: ""
 
                 Article(
                     title = title,

diff --git a/...test/kotlin/fr/nicopico/n2rss/newsletter/handlers/MITWeekendReadsNewsletterHandlerTest.kt b/...test/kotlin/fr/nicopico/n2rss/newsletter/handlers/MITWeekendReadsNewsletterHandlerTest.kt
@@ -110,5 +110,40 @@ class MITWeekendReadsNewsletterHandlerTest {
                 }
             }
         }
+
+        @Test
+        fun `should process email without article's descriptions correctly`() {
+            // GIVEN
+            val email: Email =
+                loadEmail("stubs/emails/MIT/Weekend Reads/NEW Our ambitious stories, narrated by real voice actors.eml")
+
+            // WHEN
+            val publication = handler.process(email)
+
+            // THEN
+            publication.articles shouldHaveSize 8
+            assertSoftly(publication.articles[0]) {
+                withClue("title") {
+                    title shouldBe "What are AI agents?"
+                }
+                withClue("link") {
+                    link shouldBe URL("https://technologyreview.us11.list-manage.com/track/click?u=47c1a9cec9749a8f8cbc83e78&id=35c51e4e4a&e=4fc74d6331")
+                }
+                withClue("description") {
+                    description shouldBe ""
+                }
+            }
+
+            publication.articles.map { it.title } shouldBe listOf(
+                "What are AI agents?",
+                "Is this the end of animal testing?",
+                "How generative AI could reinvent what it means to play",
+                "Is robotics about to have its own ChatGPT moment?",
+                "This architect is cutting up materials to make them stronger and lighter",
+                "The great commercial takeover of low Earth orbit",
+                "It’s time to retire the term “user”",
+                "The cost of building the perfect wave",
+            )
+        }
     }
 }