Skip to content
This repository has been archived by the owner on Jul 13, 2024. It is now read-only.

Updated computeGraphMap import #376

Closed
wants to merge 1 commit into from
Closed

Conversation

H3RSKO
Copy link

@H3RSKO H3RSKO commented Aug 25, 2020

It was giving me a 'not found' error on this without change.

It was giving me a 'not found' error on this.
@nicoespeon
Copy link
Owner

nicoespeon commented Aug 26, 2020

Hey @H3RSKO 👋
Thank you for taking the time to open the PR!

I think the problem should be somewhere else, the original import is supposed to import this file: https://github.com/nicoespeon/gitgraph.js/blob/master/packages/gitgraph-node/src/compute-graph-map/index.ts

The proposed change can't be valid because the source code is now importing a test file, which is unexpected.

Also, I remember this package wasn't quite ready to be used, so I wouldn't be surprised it's not working.

Finally, it seem CI is broken because versions are now incompatible and should be upgraded (that's not related to your PR, but it revealed that). It will be something to fix before accepting more PRs.

Unfortunately, I'm still looking for new maintainers for this project as I'm not working on it anymore: #328

In the meantime, I'm closing this PR. If it still not work on your side (it might be an editor config or something), I suggest you point to ./compute-graph-map/index.ts explicitly instead. But usually, this is the default behavior of node.

@nicoespeon nicoespeon closed this Aug 26, 2020
@H3RSKO
Copy link
Author

H3RSKO commented Aug 26, 2020

Got it. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants