Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve relative PDB paths #66

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

Systemcluster
Copy link
Contributor

In some cases the PDB path returned from pe_file.pdb_info() is relative and includes only the filename of the PDB. This results in the existence check to fail:

blondie/src/lib.rs

Lines 659 to 660 in aefddb0

let pdb_path = PathBuf::from(pdb_path);
if pdb_path.exists() {

We can check if the path is relative and join it with the path of the image in that case.

Fixes #65
Fixes flamegraph-rs/flamegraph#277

@nico-abram nico-abram merged commit 4842e0b into nico-abram:main Mar 21, 2024
3 of 4 checks passed
@nico-abram
Copy link
Owner

Thanks! Ill see if I can publish a version with this fix later

@Systemcluster Systemcluster deleted the fix-pdb-path branch March 22, 2024 00:20
@nico-abram
Copy link
Owner

Published 0.4.2 (Minor version bump) with these changes @Systemcluster . My (possibly mistaken) understanding from how flamegraph-rs depends on blondie is that any new release of it should get the change.

@Systemcluster
Copy link
Contributor Author

Thanks! I reinstalled flamegraph and it pulled the latest version. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants