Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README uses 'coveralls' command line tool instead of executing the sc… #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ksobue
Copy link

@ksobue ksobue commented Feb 11, 2016

I found "bin" entry in package.json and coveralls command is available. User does not have to specify the script file under node_modules folder.

…ript file, making user command short and precise.
@@ -11,6 +11,7 @@ Add the latest version of `coveralls` to your package.json:
```
npm install coveralls --save-dev
```
The command (`coveralls`) can be used from the command line.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true, because coveralls won't be installed globally by the command above:

npm install coveralls --save-dev

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think it makes sense to add a footnote or additional detail that sometimes coveralls does exist in the path. For example, on travis CI build jobs they append node_modules/.bin to the $PATH so you can invoke coveralls from your .travis.yml. Relevant build log on nodejs travis log:

 export PATH=./node_modules/.bin:$PATH

@revelt
Copy link

revelt commented Oct 1, 2017

Hi peeps, let's make this Sunday awesome and get this PR sorted!

@ksobue please don't get discouraged if this PR is closed, OK? Everything's fine, it's just PR, it means nothing. On the other hand, the fact that you're contributing means a lot. Only 1% of population take initiative and you're among them. Let's sort this and move on.


I did some sanity checks, to me it looks like this PR is incorrect because piping data into coveralls should not work. I might be mistaken, but I can't test mocha case --reporter mocha-lcov-reporter | coveralls as I'm an AVA fanboi and I don't have any libs using mocha and I'd rather not spend half-day assembling a new dud library for test purposes.

screen shot 2017-10-01 at 13 20 07

Same way, simple eslint call would call global install, but "lint": "./node_modules/.bin/eslint src/main.js" calls local-one, from dev-dependencies.

@shinnn please confirm that this PR is not good, so we can close this, OR suggest some amends so we can sort this.

@jtwebman
Copy link

jtwebman commented Mar 6, 2022

Since this library doesn't seem to be supported anymore I fix a bunch of things on a fork if you want to check it out and are still pulling the library into your packages: https://github.com/jtwebman/coveralls-next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants