Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navigation): use autogenerate fonction to create navigation sidebar #68

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

tomalaforge
Copy link
Collaborator

add autogenerate to generate navigation sidebar.

This way you just have to create your file and you do not forget to add it inside the conf.

What do you think?

@nartc
Copy link
Collaborator

nartc commented Sep 18, 2023

Does it automatically sort alphabetically?

@tomalaforge
Copy link
Collaborator Author

It's order alphabetically depending on the file name, not on the title name. So if the title has the same name as the file, it will work

@tomer953
Copy link
Contributor

Does it automatically sort alphabetically?

Yes :)

Sorting

Autogenerated sidebar groups are sorted by filename alphabetically. For example, a page generated from astro.md would appear above the page for starlight.md.

what about the readme? maybe remove the list? otherwise some CI needed to sort the list there

@nartc
Copy link
Collaborator

nartc commented Sep 18, 2023

Yeah probably remove the list from readme and just reference the documentation url there

@tomalaforge
Copy link
Collaborator Author

What do you mean ? I didn't understand what you want me to do

@nartc
Copy link
Collaborator

nartc commented Sep 18, 2023

@tomalaforge we can turn on autogenerate for the Astro documentation site. There's another list of utilities in the root README.md. @tomer953 and I were talking about removing the list from README.md altogether and only add a URL to the documentation site on the README.md instead.

@nx-cloud
Copy link

nx-cloud bot commented Sep 18, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d60b1cf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


⌛ The following targets are in progress

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@tomalaforge
Copy link
Collaborator Author

change made, but I think we can find a better way to express it.

Copy link
Collaborator

@nartc nartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always iterate

@nartc nartc merged commit 88221e1 into ngxtension:main Sep 18, 2023
5 checks passed
@tomer953
Copy link
Contributor

Please note that the new PR will cause installation to be before introduction.

nartc pushed a commit to tomer953/ngxtension-platform that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants