-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(call-apply): Implemented call apply Pipes #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right that pnx
is my alias 😅
Thank you for your contribution. I have some suggestions
@all-contributors please add @dmorosinotto for code |
I've put up a pull request to add @dmorosinotto! 🎉 |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 602c699. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ⌛ The following target is in progress ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
Looks like there's some timezone issue :D; probably better to convert back to UTC for the test? |
NOOOOOOoooooooo my Date PUN totally failed for timezone issue what a FAIL 👎 |
@nartc we forgot to update the main README.md to point to call-apply docs |
Hi I've implemented
CallPipe
andApplyPipe
+ added some tests and docs (hope to make it in the right places)@nartc I edited even the CONTRIBUTING.md just to fix a little typo for the nx command to create the secondary entry because I haven't the
pnx
command that you wrote, or maybe it's some kind of script/alias??And added an short section about test (because I need even the nx command to run them 😉)
Maybe another section to add is about where to put and how to write docs?
Closes #35