fix(plugin): support outputs without inline initialization #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this script would fail with a cryptic message (`cannot read property of undefined (reading includes)`) for input like: ```ts @output() myOutput: EventEmitter<string>; ``` The changes support that use case and: - Uses the initialization in the constructor to infer the type (and removes it) - Creates an initialization (`= output()`) if it doesn't exist
nartc
approved these changes
Oct 8, 2024
|
@all-contributors please add @ShacharHarshuv for code |
|
I've put up a pull request to add @ShacharHarshuv! 🎉 |
|
@ShacharHarshuv sorry that this falls on you but apparently the lint target fails because |
ShacharHarshuv
force-pushed
the
feature/outputs-with-no-initializations
branch
from
a41021a
to
6858963
Compare
|
@nartc I believe it should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this script would fail with a cryptic message (
cannot read property of undefined (reading includes)) for input like:The changes support that use case and:
= output()) if it doesn't exist