Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToSignalOptions - match 18.1 syntax #484

Merged
merged 2 commits into from
Oct 8, 2024
Merged

ToSignalOptions - match 18.1 syntax #484

merged 2 commits into from
Oct 8, 2024

Conversation

e-oz
Copy link
Contributor

@e-oz e-oz commented Aug 14, 2024

Angular 18.1 adds a generic type to ToSignalOptions - this PR reflects this change in toLazySignal()

@e-oz
Copy link
Contributor Author

e-oz commented Aug 14, 2024

Well, test fails because package.json's dep is 18.0.3, not 18.1.

@e-oz e-oz mentioned this pull request Aug 14, 2024
Open
nartc
nartc approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@nartc nartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@nartc nartc merged commit a903d2e into ngxtension:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nartc nartc nartc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-oz @nartc