feat: add migration for sfc components #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilirbeqirii
reviewed
Jun 13, 2024
| const decoratorPropertyName = property.getName(); | ||
| if (decoratorPropertyName === 'templateUrl') { | ||
| const dir = dirname(sourcePath); | ||
| const templatePath = joinPathFragments( |
There was a problem hiding this comment.
Is it possible to create a reusable function for preparing "templatePath", and then reading its content? I also noticed a similar code in the "self-closing tags" schematic.
There was a problem hiding this comment.
Good idea. Will do as a refactoring step.
eneajaho
force-pushed
the
feat/migrate-to-sfc
branch
from
598e1be
to
42ded26
Compare
eneajaho
force-pushed
the
feat/migrate-to-sfc
branch
from
42ded26
to
5a66103
Compare
nartc
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #362