Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inject-migration): add option for ES private field support #382

Conversation

ilirbeqirii
Copy link
Contributor

Closes #377

Copy link
Collaborator

@nartc nartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits

@ilirbeqirii ilirbeqirii force-pushed the inject-di-migration/add-es-private-field-support branch from 61c9650 to 5e9e5b4 Compare May 25, 2024 17:50
@ilirbeqirii
Copy link
Contributor Author

I guess it's ready to go now!

@ilirbeqirii ilirbeqirii requested a review from nartc May 26, 2024 15:10
@nartc nartc merged commit f27cabd into ngxtension:main May 29, 2024
1 check passed
@ilirbeqirii ilirbeqirii deleted the inject-di-migration/add-es-private-field-support branch May 29, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Inject Migration Enhancement]: Add ES Private Field notation support
2 participants