Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/create injectable es translation #316

Merged

Conversation

sergidt
Copy link
Contributor

@sergidt sergidt commented Mar 31, 2024

create injectable spanish translation

@nartc
Copy link
Collaborator

nartc commented Apr 2, 2024

Thank you for your contribution. Can you remove the package-lock.json since we're not using npm

@sergidt
Copy link
Contributor Author

sergidt commented Apr 2, 2024

Done! :)

@sergidt
Copy link
Contributor Author

sergidt commented Apr 3, 2024

After this PR, my intention is translate every pending page and, if you need to review some of them, as I said, I am a native Spanish speaker. ;) @nartc @eneajaho

Copy link

nx-cloud bot commented Apr 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b077191. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@sergidt
Copy link
Contributor Author

sergidt commented Apr 12, 2024

Is there any pending thing to be changed, from my side?

@sergidt sergidt force-pushed the docs/create-injectable-es-translation branch from b077191 to 2bc1c95 Compare April 29, 2024 05:57
@sergidt sergidt force-pushed the docs/create-injectable-es-translation branch from 2a1693e to af498bd Compare May 16, 2024 07:35
@sergidt sergidt closed this May 16, 2024
@sergidt
Copy link
Contributor Author

sergidt commented May 16, 2024

I supose is not a good pr, waiting for a long time...

@eneajaho eneajaho reopened this May 17, 2024
@eneajaho eneajaho force-pushed the docs/create-injectable-es-translation branch from af498bd to 2b74d49 Compare May 17, 2024 13:50
@eneajaho
Copy link
Collaborator

Hello @sergidt
Sorry for taking this long 🙏
I removed the package-lock.json and I'm merging this now.

@eneajaho eneajaho enabled auto-merge (squash) May 17, 2024 13:51
@eneajaho eneajaho merged commit 5baf2fc into ngxtension:main May 17, 2024
1 check passed
@sergidt
Copy link
Contributor Author

sergidt commented May 17, 2024

Ok, no worries, if you want I will proceed to translate others. Thanks @eneajaho

@eneajaho
Copy link
Collaborator

@sergidt
All PRs are welcome 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants