fix(plugin): add string to input generic (#375)

ngxtension · May 21, 2024 · b98b823 · b98b823
1 parent 5baf2fc
commit b98b823
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 8 deletions.
diff --git a/libs/plugin/src/generators/convert-signal-inputs/__snapshots__/generator.spec.ts.snap b/libs/plugin/src/generators/convert-signal-inputs/__snapshots__/generator.spec.ts.snap
@@ -79,10 +79,12 @@ export class MyCmp {
   withDefaultAlias = input(123, { alias: 'defaultAlias' });
   withoutDefaultAlias = input<number | undefined>(undefined, { alias: 'noDefaultAlias' });
   justAStringAlias = input('', { alias: 'stringAlias' });
-  withTransform = input<boolean, string | ''>(booleanAttribute(false), { transform: booleanAttribute });
+  withTransform = input<boolean, boolean | string>(booleanAttribute(false), { transform: booleanAttribute });
   requiredInput = input.required<string>();
   requiredWithAlias = input.required<boolean>({ alias: 'requiredAlias' });
-  requiredWithAliasAndTransform = input.required<number, string | ''>({ alias: 'transformedRequiredAlias', transform: numberAttribute });
+  requiredWithAliasAndTransform = input.required<number, number | string>({ alias: 'transformedRequiredAlias', transform: numberAttribute });
+  withTransformWithoutType = input(booleanAttribute(false), { transform: booleanAttribute });
+  requiredWithTransformWithoutType = input(numberAttribute(1), { transform: numberAttribute });
 
   @Input() set leaveMeAlone(value: number) {
     console.log('setter', value);
@@ -312,13 +314,15 @@ export class MyCmp {
   withDefaultAlias = input(123, { alias: 'defaultAlias' });
   withoutDefaultAlias = input<number | undefined>(undefined, { alias: 'noDefaultAlias' });
   justAStringAlias = input('', { alias: 'stringAlias' });
-  withTransform = input<boolean, string | ''>(booleanAttribute(false), { transform: booleanAttribute });
+  withTransform = input<boolean, boolean | string>(booleanAttribute(false), { transform: booleanAttribute });
   requiredInput = input.required<string>();
   requiredWithAlias = input.required<boolean>({ alias: 'requiredAlias' });
   /*
    * @description I go with requiredWithAliasAndTransform
    */
-  requiredWithAliasAndTransform = input.required<number, string | ''>({ alias: 'transformedRequiredAlias', transform: numberAttribute });
+  requiredWithAliasAndTransform = input.required<number, number | string>({ alias: 'transformedRequiredAlias', transform: numberAttribute });
+  withTransformWithoutType = input(booleanAttribute(false), { transform: booleanAttribute });
+  requiredWithTransformWithoutType = input(numberAttribute(1), { transform: numberAttribute });
 
   @Input() set leaveMeAlone(value: number) {
     console.log('setter', value);

diff --git a/libs/plugin/src/generators/convert-signal-inputs/generator.spec.ts b/libs/plugin/src/generators/convert-signal-inputs/generator.spec.ts
@@ -104,10 +104,12 @@ export class MyCmp {
   @Input({ alias: 'defaultAlias' }) withDefaultAlias = 123;
   @Input({ alias: 'noDefaultAlias'}) withoutDefaultAlias?: number;
   @Input('stringAlias') justAStringAlias = '';
-  @Input({ transform: booleanAttribute }) withTransform: string | '' = false;
+  @Input({ transform: booleanAttribute }) withTransform: boolean = false;
   @Input({ required: true }) requiredInput!: string;
   @Input({ required: true, alias: 'requiredAlias' }) requiredWithAlias!: boolean;
-  @Input({ required: true, alias: 'transformedRequiredAlias', transform: numberAttribute }) requiredWithAliasAndTransform!: string | '';
+  @Input({ required: true, alias: 'transformedRequiredAlias', transform: numberAttribute }) requiredWithAliasAndTransform!: number;
+  @Input({ transform: booleanAttribute }) withTransformWithoutType = false;
+  @Input({ transform: numberAttribute }) requiredWithTransformWithoutType = 1;
 
   @Input() set leaveMeAlone(value: number) {
     console.log('setter', value);
@@ -145,13 +147,15 @@ export class MyCmp {
   @Input({ alias: 'defaultAlias' }) withDefaultAlias = 123;
   @Input({ alias: 'noDefaultAlias'}) withoutDefaultAlias?: number;
   @Input('stringAlias') justAStringAlias = '';
-  @Input({ transform: booleanAttribute }) withTransform: string | '' = false;
+  @Input({ transform: booleanAttribute }) withTransform: boolean = false;
   @Input({ required: true }) requiredInput!: string;
   @Input({ required: true, alias: 'requiredAlias' }) requiredWithAlias!: boolean;
   /*
    * @description I go with requiredWithAliasAndTransform
    */
-  @Input({ required: true, alias: 'transformedRequiredAlias', transform: numberAttribute }) requiredWithAliasAndTransform!: string | '';
+  @Input({ required: true, alias: 'transformedRequiredAlias', transform: numberAttribute }) requiredWithAliasAndTransform!: number;
+  @Input({ transform: booleanAttribute }) withTransformWithoutType = false;
+  @Input({ transform: numberAttribute }) requiredWithTransformWithoutType = 1;
 
   @Input() set leaveMeAlone(value: number) {
     console.log('setter', value);

diff --git a/libs/plugin/src/generators/convert-signal-inputs/generator.ts b/libs/plugin/src/generators/convert-signal-inputs/generator.ts
@@ -92,6 +92,10 @@ function getSignalInputInitializer(
 				}
 			}
 
+			if (transformType) {
+				types.push('| string');
+			}
+
 			writer.write(types.concat('>').join(''));
 		}